Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetPopulation and HouseholdSelection models #4581

Open
wants to merge 48 commits into
base: develop
Choose a base branch
from

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Jan 20, 2025

  • AB#215791: Remove models

  • coverage backend

  • AB#231267: FE Changes (fix Payment Verification Page)

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Jan 20, 2025
@pavlo-mk pavlo-mk self-assigned this Jan 20, 2025
@pavlo-mk pavlo-mk marked this pull request as draft January 20, 2025 15:03
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 95.76271% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.78%. Comparing base (aa51409) to head (0776455).

Files with missing lines Patch % Lines
src/hct_mis_api/apps/targeting/steficon.py 0.00% 2 Missing ⚠️
src/hct_mis_api/apps/payment/api/filters.py 50.00% 1 Missing ⚠️
src/hct_mis_api/apps/registration_data/admin.py 0.00% 1 Missing ⚠️
src/hct_mis_api/apps/steficon/admin.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4581      +/-   ##
===========================================
+ Coverage    85.32%   85.78%   +0.46%     
===========================================
  Files          539      537       -2     
  Lines        36736    36019     -717     
===========================================
- Hits         31346    30900     -446     
+ Misses        5390     5119     -271     
Flag Coverage Δ
e2e 60.78% <72.03%> (+0.01%) ⬆️
unittests 84.26% <95.76%> (+0.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk changed the title WIP // Remove TargetPopulation and HouseholdSelection models Remove TargetPopulation and HouseholdSelection models Jan 31, 2025
@pavlo-mk pavlo-mk marked this pull request as ready for review January 31, 2025 14:58
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants