Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDI Access change for retrieving data from Kobo Reinstated #4507

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Dec 5, 2024

AB#198299
This pull request includes several changes to the kobo API and related files to improve the functionality and maintainability of the codebase. The most important changes include the refactoring of the KoboAPI class, updates to the environment configurations, and removal of deprecated code.

Refactoring of KoboAPI class:

  • src/hct_mis_api/apps/core/kobo/api.py: Refactored the KoboAPI class to simplify initialization and request handling, including the removal of the BusinessArea dependency and the introduction of _get_request and _get_paginated_request methods. [1] [2] [3] [4] [5]

Updates to environment configurations:

Removal of deprecated code:

Additional changes:

Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.95%. Comparing base (1d0be06) to head (87c48f2).

Files with missing lines Patch % Lines
src/hct_mis_api/migrations_script/main.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4507      +/-   ##
===========================================
+ Coverage    84.66%   84.95%   +0.29%     
===========================================
  Files          506      506              
  Lines        36234    36172      -62     
===========================================
+ Hits         30677    30731      +54     
+ Misses        5557     5441     -116     
Flag Coverage Δ
e2e 62.70% <26.92%> (+0.09%) ⬆️
unittests 83.19% <98.07%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant