Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Permissions new rework #4409

Draft
wants to merge 86 commits into
base: develop
Choose a base branch
from
Draft

Conversation

pkujawa
Copy link
Contributor

@pkujawa pkujawa commented Nov 5, 2024

No description provided.

Rename UserRole -> RoleAssignment
Test model constraints
@pkujawa pkujawa added the backend Changes in BE code label Nov 5, 2024
@pkujawa pkujawa self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 50.97765% with 351 lines in your changes missing coverage. Please review.

Project coverage is 48.75%. Comparing base (aa51409) to head (784c48e).

Files with missing lines Patch % Lines
..._mis_api/apps/account/migrations/0008_migration.py 55.28% 55 Missing ⚠️
src/hct_mis_api/apps/core/backends.py 22.22% 49 Missing ⚠️
src/hct_mis_api/apps/account/admin/user_role.py 34.14% 27 Missing ⚠️
src/hct_mis_api/apps/account/models.py 74.52% 27 Missing ⚠️
src/hct_mis_api/apps/household/schema.py 52.83% 25 Missing ⚠️
src/hct_mis_api/apps/core/admin.py 14.81% 23 Missing ⚠️
src/hct_mis_api/apps/account/celery_tasks.py 0.00% 19 Missing ⚠️
src/hct_mis_api/apps/core/base_test_case.py 0.00% 18 Missing ⚠️
src/hct_mis_api/apps/core/utils.py 12.50% 14 Missing ⚠️
src/hct_mis_api/apps/account/admin/partner.py 42.85% 12 Missing ⚠️
... and 24 more

❌ Your patch check has failed because the patch coverage (50.97%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (aa51409) and HEAD (784c48e). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa51409) HEAD (784c48e)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4409       +/-   ##
============================================
- Coverage    85.32%   48.75%   -36.58%     
============================================
  Files          539      543        +4     
  Lines        36736    37021      +285     
============================================
- Hits         31346    18050    -13296     
- Misses        5390    18971    +13581     
Flag Coverage Δ
e2e 48.75% <50.97%> (-12.02%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkujawa and others added 26 commits November 26, 2024 00:01
… on account models, apply new logic for rest, some graphql requests
…gnments with validation against allowed BAs, tests
…ixtures for the user and partner permissions
… specific scope for ftontend, additional model constraints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant