Allow FedCm disabled response #3209
Open
+59
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
PF4Public
approved these changes
Feb 23, 2025
|
I would suggest keeping the related issue open for longer time after merging this PR and leaving a comment that it should be fixed with the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we handle part of disabling FedCm, rather than rejecting the request this returns that it is disabled.
I believe this should solve some of the youtube issues mentioned in #3012. It seems like youtube had been experimenting with integrating FedCm and finally made the changes generally available a few days ago.
There are reports for other browsers having the same issue, so it's possible they also don't handle that the way the site expects. All I can suggest for users of other browsers is to try launching with
--disabled-features=FedCmon chromium-based browsers, and on firefox use an older user-agent since it doesn't support the API.