Apply nl_func_var_def_blk only to first block #3242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This is a small fix that addresses
nl_func_var_def_blk
applying to all var block in a function, not only the top one.Consider the following example:
Say you have
nl_func_var_def_blk=1
, this would give before this fix:After this fix, you get the correct:
This is not the final fix though.
Ideally, if var block is preceded by any other (non-var) block,
nl_func_var_def_blk
should not apply as well (because not func top).For instance, you would still get