Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency react-router-dom to ^6.23.1 #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 1, 2023

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
react-router-dom (source) ^6.18.0 -> ^6.23.1 age adoption passing confidence

Release Notes

remix-run/react-router (react-router-dom)

v6.23.1

Compare Source

Patch Changes

v6.23.0

Compare Source

Minor Changes
  • Add a new unstable_dataStrategy configuration option (#​11098)
    • This option allows Data Router applications to take control over the approach for executing route loaders and actions
    • The default implementation is today's behavior, to fetch all loaders in parallel, but this option allows users to implement more advanced data flows including Remix single-fetch, middleware/context APIs, automatic loader caching, and more
Patch Changes

v6.22.3

Compare Source

Patch Changes

v6.22.2

Compare Source

Patch Changes

v6.22.1

Compare Source

v6.22.0

Compare Source

Minor Changes
  • Include a window__reactRouterVersion tag for CWV Report detection (#​11222)
Patch Changes

v6.21.3

Compare Source

Patch Changes
  • Fix NavLink isPending when a basename is used (#​11195)
  • Remove leftover unstable_ prefix from Blocker/BlockerFunction types (#​11187)
  • Updated dependencies:

v6.21.2

Compare Source

v6.21.1

Compare Source

Patch Changes

v6.21.0

Compare Source

Minor Changes
  • Add a new future.v7_relativeSplatPath flag to implement a breaking bug fix to relative routing when inside a splat route. (#​11087)

    This fix was originally added in #​10983 and was later reverted in #​11078 because it was determined that a large number of existing applications were relying on the buggy behavior (see #​11052)

    The Bug
    The buggy behavior is that without this flag, the default behavior when resolving relative paths is to ignore any splat (*) portion of the current route path.

    The Background
    This decision was originally made thinking that it would make the concept of nested different sections of your apps in <Routes> easier if relative routing would replace the current splat:

    <BrowserRouter>
      <Routes>
        <Route path="/" element={<Home />} />
        <Route path="dashboard/*" element={<Dashboard />} />
      </Routes>
    </BrowserRouter>

    Any paths like /dashboard, /dashboard/team, /dashboard/projects will match the Dashboard route. The dashboard component itself can then render nested <Routes>:

    function Dashboard() {
      return (
        <div>
          <h2>Dashboard</h2>
          <nav>
            <Link to="/">Dashboard Home</Link>
            <Link to="team">Team</Link>
            <Link to="projects">Projects</Link>
          </nav>
    
          <Routes>
            <Route path="/" element={<DashboardHome />} />
            <Route path="team" element={<DashboardTeam />} />
            <Route path="projects" element={<DashboardProjects />} />
          </Routes>
        </div>
      );
    }

    Now, all links and route paths are relative to the router above them. This makes code splitting and compartmentalizing your app really easy. You could render the Dashboard as its own independent app, or embed it into your large app without making any changes to it.

    The Problem

    The problem is that this concept of ignoring part of a path breaks a lot of other assumptions in React Router - namely that "." always means the current location pathname for that route. When we ignore the splat portion, we start getting invalid paths when using ".":

    // If we are on URL /dashboard/team, and we want to link to /dashboard/team:
    function DashboardTeam() {
      // ❌ This is broken and results in <a href="/dashboard">
      return <Link to=".">A broken link to the Current URL</Link>;
    
      // ✅ This is fixed but super unintuitive since we're already at /dashboard/team!
      return <Link to="./team">A broken link to the Current URL</Link>;
    }

    We've also introduced an issue that we can no longer move our DashboardTeam component around our route hierarchy easily - since it behaves differently if we're underneath a non-splat route, such as /dashboard/:widget. Now, our "." links will, properly point to ourself inclusive of the dynamic param value so behavior will break from it's corresponding usage in a /dashboard/* route.

    Even worse, consider a nested splat route configuration:

    <BrowserRouter>
      <Routes>
        <Route path="dashboard">
          <Route path="*" element={<Dashboard />} />
        </Route>
      </Routes>
    </BrowserRouter>

    Now, a <Link to="."> and a <Link to=".."> inside the Dashboard component go to the same place! That is definitely not correct!

    Another common issue arose in Data Routers (and Remix) where any <Form> should post to it's own route action if you the user doesn't specify a form action:

    let router = createBrowserRouter({
      path: "/dashboard",
      children: [
        {
          path: "*",
          action: dashboardAction,
          Component() {
            // ❌ This form is broken!  It throws a 405 error when it submits because
            // it tries to submit to /dashboard (without the splat value) and the parent
            // `/dashboard` route doesn't have an action
            return <Form method="post">...</Form>;
          },
        },
      ],
    });

    This is just a compounded issue from the above because the default location for a Form to submit to is itself (".") - and if we ignore the splat portion, that now resolves to the parent route.

    The Solution
    If you are leveraging this behavior, it's recommended to enable the future flag, move your splat to it's own route, and leverage ../ for any links to "sibling" pages:

    <BrowserRouter>
      <Routes>
        <Route path="dashboard">
          <Route index path="*" element={<Dashboard />} />
        </Route>
      </Routes>
    </BrowserRouter>
    
    function Dashboard() {
      return (
        <div>
          <h2>Dashboard</h2>
          <nav>
            <Link to="..">Dashboard Home</Link>
            <Link to="../team">Team</Link>
            <Link to="../projects">Projects</Link>
          </nav>
    
          <Routes>
            <Route path="/" element={<DashboardHome />} />
            <Route path="team" element={<DashboardTeam />} />
            <Route path="projects" element={<DashboardProjects />} />
          </Router>
        </div>
      );
    }

    This way, . means "the full current pathname for my route" in all cases (including static, dynamic, and splat routes) and .. always means "my parents pathname".

Patch Changes

v6.20.1

Compare Source

Patch Changes

v6.20.0

Compare Source

Minor Changes
  • Export the PathParam type from the public API (#​10719)
Patch Changes

v6.19.0

Compare Source

Minor Changes
  • Add unstable_flushSync option to useNavigate/useSumbit/fetcher.load/fetcher.submit to opt-out of React.startTransition and into ReactDOM.flushSync for state updates (#​11005)
  • Allow unstable_usePrompt to accept a BlockerFunction in addition to a boolean (#​10991)
Patch Changes
  • Fix issue where a changing fetcher key in a useFetcher that remains mounted wasn't getting picked up (#​11009)
  • Fix useFormAction which was incorrectly inheriting the ?index query param from child route action submissions (#​11025)
  • Fix NavLink active logic when to location has a trailing slash (#​10734)
  • Updated dependencies:

Configuration

📅 Schedule: Branch creation - "before 4am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@stackblitz
Copy link

stackblitz bot commented Jul 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2023

⚠️ No Changeset found

Latest commit: 33e09f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

Deploy preview for size-limit ready!

✅ Preview
https://size-limit-a4duq8f8q-jounqins-projects.vercel.app

Built with commit 33e09f8.
This pull request is being automatically deployed with vercel-action

@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.14.1 chore(deps): update dependency react-router-dom to ^6.14.2 Jul 17, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 4dd9de7 to 8a2f382 Compare July 17, 2023 23:03
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.14.2 chore(deps): update dependency react-router-dom to ^6.15.0 Aug 10, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 8a2f382 to c91c402 Compare August 10, 2023 16:42
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.15.0 chore(deps): update dependency react-router-dom to ^6.16.0 Sep 13, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from c91c402 to 9b14764 Compare September 13, 2023 17:39
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.16.0 chore(deps): update dependency react-router-dom to ^6.17.0 Oct 16, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 9b14764 to 0262508 Compare October 16, 2023 19:14
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 0262508 to 003bf04 Compare October 31, 2023 17:18
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.17.0 chore(deps): update dependency react-router-dom to ^6.18.0 Oct 31, 2023
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.18.0 chore(deps): update dependency react-router-dom to ^6.18.0 - autoclosed Nov 10, 2023
@renovate renovate bot closed this Nov 10, 2023
@renovate renovate bot deleted the renovate/react-router-monorepo branch November 10, 2023 07:41
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.18.0 - autoclosed chore(deps): update dependency react-router-dom to ^6.18.0 Nov 16, 2023
@renovate renovate bot reopened this Nov 16, 2023
@renovate renovate bot restored the renovate/react-router-monorepo branch November 16, 2023 16:16
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.18.0 chore(deps): update dependency react-router-dom to ^6.19.0 Nov 16, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 003bf04 to 3f93ef0 Compare November 16, 2023 19:33
Copy link
Contributor

github-actions bot commented Nov 16, 2023

size-limit report 📦

Path Size
./packages/node-esbuild/lib/index.js 635 B (0%)
./packages/preset-node-lib/lib/index.js 141 B (0%)

@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.19.0 chore(deps): update dependency react-router-dom to ^6.20.0 Nov 22, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 3f93ef0 to ea80adb Compare November 22, 2023 17:24
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.20.0 chore(deps): update dependency react-router-dom to ^6.20.1 Dec 1, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from ea80adb to f00d1b5 Compare December 1, 2023 20:10
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.20.1 chore(deps): update dependency react-router-dom to ^6.21.0 Dec 13, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from f00d1b5 to 1dc188e Compare December 13, 2023 22:34
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 1dc188e to 78c4dbd Compare December 21, 2023 18:17
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.21.0 chore(deps): update dependency react-router-dom to ^6.21.1 Dec 21, 2023
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 78c4dbd to c82f2f9 Compare January 11, 2024 19:43
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.21.1 chore(deps): update dependency react-router-dom to ^6.21.2 Jan 11, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from c82f2f9 to 64e4ca1 Compare January 18, 2024 21:59
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.21.2 chore(deps): update dependency react-router-dom to ^6.21.3 Jan 18, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from 64e4ca1 to f223bca Compare February 1, 2024 22:46
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.21.3 chore(deps): update dependency react-router-dom to ^6.22.0 Feb 1, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from f223bca to b8cc18b Compare February 16, 2024 22:24
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.22.0 chore(deps): update dependency react-router-dom to ^6.22.1 Feb 16, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from b8cc18b to da9ed95 Compare February 28, 2024 21:49
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.22.1 chore(deps): update dependency react-router-dom to ^6.22.2 Feb 28, 2024
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.22.2 chore(deps): update dependency react-router-dom to ^6.22.3 Mar 7, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from da9ed95 to bc77896 Compare March 7, 2024 18:38
@renovate renovate bot enabled auto-merge (rebase) March 20, 2024 13:24
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from bc77896 to f5a7cb0 Compare April 23, 2024 18:29
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.22.3 chore(deps): update dependency react-router-dom to ^6.23.0 Apr 23, 2024
@renovate renovate bot force-pushed the renovate/react-router-monorepo branch from f5a7cb0 to 33e09f8 Compare May 10, 2024 19:38
@renovate renovate bot changed the title chore(deps): update dependency react-router-dom to ^6.23.0 chore(deps): update dependency react-router-dom to ^6.23.1 May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants