Reimplement WRSCs as legacy object syntax #1052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to use legacy syntax for WFM to read rules
alexiswl
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the WorkflowRunStateChange event structure by flattening nested workflow properties and standardizing field naming. The changes convert from a nested structure with workflow.name, workflow.version, and libraries to flat fields workflowName, workflowVersion, and linkedLibraries to align with schema definitions.
Key changes:
- Flattened workflow properties from nested to top-level fields
- Renamed
librariestolinkedLibrariesfor consistency - Updated event emission in both state change and ready event handlers
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/workload/components/sfn-icav2-state-change-event-handler/step_functions_templates/icav2_get_workflow_status_and_raise_internal_event.asl.json |
Refactored event detail structure to use flat workflowName, workflowVersion, and linkedLibraries fields |
lib/workload/components/sfn-generate-workflowrunstatechange-ready-event/step_functions_templates/workflowrunstatechange_generate_ready_step_function_template.asl.json |
Updated ready event structure to match the flattened schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...handler/step_functions_templates/icav2_get_workflow_status_and_raise_internal_event.asl.json
Show resolved
Hide resolved
...ep_functions_templates/workflowrunstatechange_generate_ready_step_function_template.asl.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to use legacy syntax for WFM to read rules, small partial rollback for legacy services.