Skip to content

Conversation

@alexiswl
Copy link
Member

Also removed a bunch of stateful stacks that weren't taken the first time around

Also removed a bunch of stateful stacks that weren't taken the first time around
@alexiswl alexiswl requested a review from Copilot October 20, 2025 04:39
@alexiswl alexiswl self-assigned this Oct 20, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the BCLConvert manager stack from both the stateless and stateful stack collections by commenting out or deleting the instantiation code. Additionally, it removes several stateful pipeline table stacks that were previously active.

Key changes:

  • Commented out the BclConvertManagerStack instantiation in the stateless stack collection
  • Removed instantiation of multiple stateful stacks: Cttsov2Icav2PipelineTable, OraCompressionIcav2PipelineTable, BclConvertTable, PierianDxPipelineTable, OncoanalyserNfPipelineTable, and SashNfPipelineTable
  • Cleaned up imports by removing unused class imports while retaining their Props type imports

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lib/workload/stateless/statelessStackCollectionClass.ts Moved BclConvertManagerStack instantiation from active code to commented section
lib/workload/stateful/statefulStackCollectionClass.ts Removed instantiation of multiple pipeline table stacks and cleaned up imports to remove unused class imports

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexiswl alexiswl added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit d24ddd7 Oct 20, 2025
4 of 5 checks passed
@alexiswl alexiswl deleted the chore/drop-bclconvert-manager branch October 20, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants