Stacky clean up #1046
Merged
Stacky clean up #1046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated glues
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes deprecated glue constructs and their associated stack configurations from the codebase. The changes clean up unused pipeline manager stacks and their corresponding glue handler constructs that are no longer needed.
- Removed imports for deprecated stack classes while keeping their props interfaces
- Commented out instantiation of deprecated pipeline manager stacks and moved them to commented sections
- Commented out deprecated glue handler construct instantiations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| lib/workload/stateless/statelessStackCollectionClass.ts | Removes deprecated stack class imports and comments out their instantiations while preserving props imports |
| lib/workload/stateless/stacks/stacky-mcstackface/glue-constructs/index.ts | Comments out deprecated glue handler construct instantiations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+255
to
+272
| // this.oraDecompressionManagerStack = new OraDecompressionManagerStack( | ||
| // scope, | ||
| // 'OraDecompressionManagerStack', | ||
| // { | ||
| // ...this.createTemplateProps(env, 'OraDecompressionManagerStack'), | ||
| // ...statelessConfiguration.oraDecompressionManagerStackProps, | ||
| // } | ||
| // ); | ||
| // | ||
| // this.cttsov2Icav2PipelineManagerStack = new Cttsov2Icav2PipelineManagerStack( | ||
| // scope, | ||
| // 'Cttsov2Icav2PipelineManagerStack', | ||
| // { | ||
| // ...this.createTemplateProps(env, 'Cttsov2Icav2PipelineManagerStack'), | ||
| // ...statelessConfiguration.cttsov2Icav2PipelineManagerStackProps, | ||
| // } | ||
| // ); | ||
|
|
There was a problem hiding this comment.
These commented-out stack instantiations should be removed entirely rather than left as commented code. Commented code can cause confusion and should be cleaned up during deprecation.
Suggested change
| // this.oraDecompressionManagerStack = new OraDecompressionManagerStack( | |
| // scope, | |
| // 'OraDecompressionManagerStack', | |
| // { | |
| // ...this.createTemplateProps(env, 'OraDecompressionManagerStack'), | |
| // ...statelessConfiguration.oraDecompressionManagerStackProps, | |
| // } | |
| // ); | |
| // | |
| // this.cttsov2Icav2PipelineManagerStack = new Cttsov2Icav2PipelineManagerStack( | |
| // scope, | |
| // 'Cttsov2Icav2PipelineManagerStack', | |
| // { | |
| // ...this.createTemplateProps(env, 'Cttsov2Icav2PipelineManagerStack'), | |
| // ...statelessConfiguration.cttsov2Icav2PipelineManagerStackProps, | |
| // } | |
| // ); |
Comment on lines
+104
to
+113
| // const handyPal = new OncoanalyserGlueHandlerConstruct(this, 'handyPal', { | ||
| // /* Event Objects */ | ||
| // eventBusObj: props.eventBusObj, | ||
| // /* Tables */ | ||
| // oncoanalyserGlueTableObj: props.oncoanalyserGlueTableObj, | ||
| // /* SSM Parameter Objects */ | ||
| // analysisCacheUriSsmParameterObj: props.analysisCacheUriSsmParameterObj, | ||
| // analysisLogsUriSsmParameterObj: props.analysisLogsUriSsmParameterObj, | ||
| // analysisOutputUriSsmParameterObj: props.analysisOutputUriSsmParameterObj, | ||
| // }); |
There was a problem hiding this comment.
This commented-out glue handler construct should be removed entirely rather than left as commented code. Leaving deprecated code commented out can lead to confusion and maintenance overhead.
Comment on lines
+118
to
+130
| // const jb_weld = new Cttsov2GlueHandlerConstruct(this, 'jb_weld', { | ||
| // /* Event Bus */ | ||
| // eventBusObj: props.eventBusObj, | ||
| // /* Tables */ | ||
| // cttsov2GlueTableObj: props.cttsov2GlueTableObj, | ||
| // /* SSM Parameters */ | ||
| // icav2ProjectIdSsmParameterObj: props.icav2ProjectIdSsmParameterObj, | ||
| // analysisOutputUriSsmParameterObj: props.analysisOutputUriSsmParameterObj, | ||
| // analysisCacheUriSsmParameterObj: props.analysisCacheUriSsmParameterObj, | ||
| // analysisLogsUriSsmParameterObj: props.analysisLogsUriSsmParameterObj, | ||
| // /* Secrets */ | ||
| // icav2AccessTokenSecretObj: props.icav2AccessTokenSecretObj, | ||
| // }); |
There was a problem hiding this comment.
This commented-out glue handler construct should be removed entirely rather than left as commented code. Leaving deprecated code commented out can lead to confusion and maintenance overhead.
Suggested change
| // const jb_weld = new Cttsov2GlueHandlerConstruct(this, 'jb_weld', { | |
| // /* Event Bus */ | |
| // eventBusObj: props.eventBusObj, | |
| // /* Tables */ | |
| // cttsov2GlueTableObj: props.cttsov2GlueTableObj, | |
| // /* SSM Parameters */ | |
| // icav2ProjectIdSsmParameterObj: props.icav2ProjectIdSsmParameterObj, | |
| // analysisOutputUriSsmParameterObj: props.analysisOutputUriSsmParameterObj, | |
| // analysisCacheUriSsmParameterObj: props.analysisCacheUriSsmParameterObj, | |
| // analysisLogsUriSsmParameterObj: props.analysisLogsUriSsmParameterObj, | |
| // /* Secrets */ | |
| // icav2AccessTokenSecretObj: props.icav2AccessTokenSecretObj, | |
| // }); |
Comment on lines
+186
to
200
| // const nails = new PieriandxGlueHandlerConstruct(this, 'nails', { | ||
| // /* Event Bus */ | ||
| // eventBusObj: props.eventBusObj, | ||
| // | ||
| // /* Tables */ | ||
| // pieriandxGlueTableObj: props.pieriandxGlueTableObj, | ||
| // | ||
| // /* Secrets */ | ||
| // icav2AccessTokenSecretObj: props.icav2AccessTokenSecretObj, | ||
| // | ||
| // /* Extras */ | ||
| // pieriandxProjectInfoSsmParameterObj: props.pieriandxProjectInfoSsmParameterObj, | ||
| // redcapLambdaObj: props.redcapLambdaObj, | ||
| // }); | ||
|
|
There was a problem hiding this comment.
This commented-out glue handler construct should be removed entirely rather than left as commented code. Leaving deprecated code commented out can lead to confusion and maintenance overhead.
Suggested change
| // const nails = new PieriandxGlueHandlerConstruct(this, 'nails', { | |
| // /* Event Bus */ | |
| // eventBusObj: props.eventBusObj, | |
| // | |
| // /* Tables */ | |
| // pieriandxGlueTableObj: props.pieriandxGlueTableObj, | |
| // | |
| // /* Secrets */ | |
| // icav2AccessTokenSecretObj: props.icav2AccessTokenSecretObj, | |
| // | |
| // /* Extras */ | |
| // pieriandxProjectInfoSsmParameterObj: props.pieriandxProjectInfoSsmParameterObj, | |
| // redcapLambdaObj: props.redcapLambdaObj, | |
| // }); |
Comment on lines
+239
to
+248
| // const tRex = new OncoanalyserBothSashGlueHandlerConstruct(this, 'trex', { | ||
| // /* Event Objects */ | ||
| // eventBusObj: props.eventBusObj, | ||
| // /* Tables */ | ||
| // oncoanalyserBothSashGlueTableObj: props.oncoanalyserBothSashGlueTableObj, | ||
| // /* SSM Parameter Objects */ | ||
| // analysisCacheUriSsmParameterObj: props.analysisCacheUriSsmParameterObj, | ||
| // analysisLogsUriSsmParameterObj: props.analysisLogsUriSsmParameterObj, | ||
| // analysisOutputUriSsmParameterObj: props.analysisOutputUriSsmParameterObj, | ||
| // }); |
There was a problem hiding this comment.
This commented-out glue handler construct should be removed entirely rather than left as commented code. Leaving deprecated code commented out can lead to confusion and maintenance overhead.
Suggested change
| // const tRex = new OncoanalyserBothSashGlueHandlerConstruct(this, 'trex', { | |
| // /* Event Objects */ | |
| // eventBusObj: props.eventBusObj, | |
| // /* Tables */ | |
| // oncoanalyserBothSashGlueTableObj: props.oncoanalyserBothSashGlueTableObj, | |
| // /* SSM Parameter Objects */ | |
| // analysisCacheUriSsmParameterObj: props.analysisCacheUriSsmParameterObj, | |
| // analysisLogsUriSsmParameterObj: props.analysisLogsUriSsmParameterObj, | |
| // analysisOutputUriSsmParameterObj: props.analysisOutputUriSsmParameterObj, | |
| // }); |
reisingerf
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated glues