Allow stacky event rules to listen to new events while providing SFNs targets with the legacy objects #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeps sfns the same by updating the event targets back to legacy wfm schema
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR restructures event objects to support new event patterns while maintaining backward compatibility for Step Function targets. The changes update the event schema to nest workflow information under a workflow object and rename linkedLibraries to libraries, while providing SFN targets with the legacy flattened object structure.
- Updates event rule patterns to listen for nested
workflow.nameinstead of flatworkflowName - Transforms event data for SFN targets to maintain legacy object structure
- Renames
linkedLibrariesfield tolibrariesin event objects
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/workload/stateless/stacks/stacky-mcstackface/glue-constructs/roket/part_2/umccrise-and-wts-complete-to-rnasum-draft/index.ts | Updates event rule pattern and transforms input for SFN target to legacy format |
| lib/workload/stateless/stacks/stacky-mcstackface/glue-constructs/pva/part_2/tn-complete-to-umccrise-draft/index.ts | Updates event rule pattern and transforms input for SFN target to legacy format |
| lib/workload/stateless/stacks/stacky-mcstackface/glue-constructs/kwik/part_4/push-fastq-list-row-qc-complete-event/index.ts | Updates event rule pattern and transforms input for SFN target to legacy format |
| lib/workload/components/sfn-icav2-state-change-event-handler/step_functions_templates/icav2_get_workflow_status_and_raise_internal_event.asl.json | Restructures event payload to use nested workflow object and renames linkedLibraries to libraries |
| lib/workload/components/sfn-icav2-ready-event-handler/index.ts | Updates event rule pattern and transforms input for SFN target to legacy format |
| lib/workload/components/sfn-generate-workflowrunstatechange-ready-event/step_functions_templates/workflowrunstatechange_generate_ready_step_function_template.asl.json | Restructures event payload to use nested workflow object and renames linkedLibraries to libraries |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
reisingerf
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.