Flamegraphs #137
Flamegraphs #137
Conversation
…ts, both locally and on the target CI environment (GHA).
…enchmarks and see if release PR is working
…ing deprecated :-S)... more inline format clippy warnings that do not show locally despite cargo clean-ing and making sure same versions are running on CI and local :/
|
After bumping into flamegraph-rs/flamegraph#39 (comment), I realised that we don't need this to be integrated with Criterion anymore:
I'll refactor accordingly and integrate that SVG into the EDIT: Those stack traces contain a significant amount of bench-related stack calls that we don't want, I'll learn how to filter those so that it only includes the EDIT2: Couple of issues reported upstream worth tracking: flamegraph-rs/flamegraph#247 and flamegraph-rs/flamegraph#246 |
…happen in DTrace under OSX? See: flamegraph-rs/flamegraph#248 Also check contents of restricted GHA kernel memory map.
|
This needs to be followed up with |
…factoring into htsget-benchmarks after signing up for bencher.dev
…htsget-rs+htsget-refserver benchmark pairing. Aim is for them to run separatedly so that they are easier to paralelise on GHA CI/CD, otherwise we'll see timeouts often (we just had one now as I was integrating bencher.dev). Also we'll have a template for third party comparisons. Commented most of the search benchmarks to iterate more quickly now
|
Followup on profiling fixes/discussion happening on koute/not-perf#32 and cmyr/cargo-instruments#84 (comment) |
|
Good read and tips: https://ochagavia.nl/blog/continuous-benchmarking-for-rustls/ |
Adds a custom profiler to criterion-rs which plots flamegraphs, following this blogpost.
How to test this:
cargo flamegraph --deterministic --flamechart -o flamechart.svg --bench search-benchmarks -- --benchSeemingly there's an issue with Criterion's custom profiler registration as the .SVG output files are not generated... yet.