Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make sure umap.properties.slideshow is defined #2583

Merged
merged 2 commits into from
Mar 28, 2025

Conversation

yohanboniface
Copy link
Member

No description provided.

@yohanboniface
Copy link
Member Author

Not sure why it fails while it is said as "widely available" here:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Nullish_coalescing_assignment

Screenshot From 2025-03-19 09-35-07

@davidbgk
Copy link
Contributor

@davidbgk
Copy link
Contributor

I check and npx eslint umap/static/umap/js/ doesn't propose anything better with the new baseline, I guess we'll have to figure it out by ourselves 😬

@yohanboniface yohanboniface merged commit dcf5f1a into master Mar 28, 2025
3 checks passed
@yohanboniface yohanboniface deleted the default-slideshow branch March 28, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants