Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle multiple dataUrl parameters on map load #1943

Merged
merged 3 commits into from
Jun 26, 2024
Merged

feat: handle multiple dataUrl parameters on map load #1943

merged 3 commits into from
Jun 26, 2024

Conversation

davidbgk
Copy link
Contributor

No description provided.

yohanboniface
yohanboniface approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@yohanboniface yohanboniface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, but given all other parameters are unique, in particular dataFormat (but color, labelKey or popupShape too), I feel it's a bit asymmetrical. But let's see how it will be used!

@davidbgk
Copy link
Contributor Author

I added users' documentation related to that topic:
Capture d’écran, le 2024-06-26 à 13 40 50

Capture d’écran, le 2024-06-26 à 13 41 03

@yohanboniface
Copy link
Member

Cool! Do we also mention the data parameter ?

@davidbgk
Copy link
Contributor Author

https://media3.giphy.com/media/rvaQRHCzisFeo/giphy.mp4#height=182&width=293&isvideo=true

@davidbgk davidbgk merged commit b01a194 into master Jun 26, 2024
2 of 4 checks passed
@davidbgk davidbgk deleted the multiple-dataurl-onload branch June 26, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yohanboniface yohanboniface yohanboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidbgk @yohanboniface