v2.17.0 #3294

mikecao · 2025-03-08T05:23:22Z

No description provided.

Fix #3255

Enhance Batch Processing by Reusing Existing Event Handling Logic

Fix duplicate key errors

…on to /api/* endpoints Signed-off-by: Louis Vallat <[email protected]>

add CORS headers to any value of COLLECT_API_ENDPOINT in addition to /api/* endpoints

Allow populating event's createdAt on the send endpoint

Fix journey report

vercel · 2025-03-08T05:23:27Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
umami	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2025 5:23am

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
umami-analytics-eu	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2025 5:23am
umami-analytics-us	⬜️ Ignored (Inspect)	Visit Preview	Mar 8, 2025 5:23am
umami-mysql	⬜️ Ignored (Inspect)		Mar 8, 2025 5:23am
umami-postgresql	⬜️ Ignored (Inspect)		Mar 8, 2025 5:23am

greptile-apps

PR Summary

This PR introduces significant updates for version 2.17.0, focusing on enhanced testing infrastructure and user management functionality.

Added comprehensive Cypress E2E tests in cypress/e2e/user.cy.ts and cypress/e2e/api.cy.ts for user management operations
Added optional createdAt parameter in saveEvent, saveEventData, and saveSessionData functions for better timestamp control
Added Do Not Track (DNT) support in src/tracker/index.js with browser detection and data-do-not-track attribute
Added data-test attributes across user management components for improved testability
Made password field optional in user updates and added UUID customization for user creation

Note: Some dependencies in package.json reference future versions (React 19, TypeScript 5.5.3) which could cause compatibility issues.

_{💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!}

_{42 file(s) reviewed, 34 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-03-08T05:24:03Z

cypress/e2e/api.cy.ts

@@ -0,0 +1,29 @@
+describe('Website tests', () => {


logic: Test suite description 'Website tests' is incorrect for a user creation test

greptile-apps · 2025-03-08T05:24:04Z

cypress/e2e/api.cy.ts

+    cy.login(Cypress.env('umami_user'), Cypress.env('umami_password'));
+  });
+
+  //let userId;


style: Remove commented out code that is not being used

Suggested change

//let userId;

greptile-apps · 2025-03-08T05:24:04Z

cypress/e2e/api.cy.ts

+        },
+        body: userPost,
+      }).then(response => {
+        //userId = response.body.id;


style: Remove commented out code that is not being used

Suggested change

//userId = response.body.id;

greptile-apps · 2025-03-08T05:24:19Z

.eslintrc.json

+    "plugin:@typescript-eslint/eslint-recommended",
    "plugin:@typescript-eslint/recommended",


style: Redundant inclusion of both eslint-recommended and recommended plugins. The typescript-eslint/recommended already includes eslint-recommended rules.

Suggested change

"plugin:@typescript-eslint/eslint-recommended",

"plugin:@typescript-eslint/recommended",

"plugin:@typescript-eslint/recommended",

"plugin:@typescript-eslint/recommended",

greptile-apps · 2025-03-08T05:24:20Z

cypress/e2e/user.cy.ts

@@ -0,0 +1,65 @@
+describe('Website tests', () => {


logic: Test suite name 'Website tests' is incorrect - should be 'User tests' or 'User management tests' since it's testing user functionality

greptile-apps · 2025-03-08T05:30:50Z

src/queries/sql/events/saveEventData.ts

@@ -77,7 +79,7 @@ async function clickhouseQuery(data: {
      string_value: getStringValue(value, dataType),
      number_value: dataType === DATA_TYPE.number ? value : null,
      date_value: dataType === DATA_TYPE.date ? getUTCString(value) : null,
-      created_at: createdAt,
+      created_at: getUTCString(createdAt),


logic: createdAt is optional but no null check before passing to getUTCString. This could cause runtime errors if createdAt is undefined.

Suggested change

created_at: getUTCString(createdAt),

created_at: createdAt ? getUTCString(createdAt) : null,

greptile-apps · 2025-03-08T05:30:51Z

src/queries/sql/events/saveEventData.ts

@@ -42,6 +43,7 @@ async function relationalQuery(data: {
    numberValue: a.dataType === DATA_TYPE.number ? a.value : null,
    dateValue: a.dataType === DATA_TYPE.date ? new Date(a.value) : null,


style: Potential invalid date creation - new Date(a.value) could return Invalid Date if a.value is malformed. Consider adding validation.

greptile-apps · 2025-03-08T05:30:54Z

src/queries/sql/sessions/saveSessionData.ts

      date_value: dataType === DATA_TYPE.date ? getUTCString(value) : null,
-      created_at: createdAt,
+      created_at: getUTCString(createdAt),


logic: No default value or null check for createdAt. If createdAt is undefined, getUTCString(undefined) could cause issues.

greptile-apps · 2025-03-08T05:31:07Z

src/tracker/index.js

+    const dnt = doNotTrack || ndnt || msdnt;
+    return dnt === 1 || dnt === '1' || dnt === 'yes';


style: The hasDoNotTrack function should cache the DNT value since it's unlikely to change during a session. Currently it recalculates on every check.

greptile-apps · 2025-03-08T05:31:08Z

src/tracker/index.js

+    const dnt = doNotTrack || ndnt || msdnt;
+    return dnt === 1 || dnt === '1' || dnt === 'yes';


logic: The dnt variable shadows the outer dnt constant from line 25. This could cause confusion and potential bugs.

Suggested change

const dnt = doNotTrack || ndnt || msdnt;

return dnt === 1 || dnt === '1' || dnt === 'yes';

const dntValue = doNotTrack || ndnt || msdnt;

return dntValue === 1 || dntValue === '1' || dntValue === 'yes';

shrutesh1 and others added 30 commits February 20, 2025 11:11

Added batching

de8f5c4

Make user id optional.

75b0b2e

Fix duplicate key errors

bdeaa9e

Add keys for RealTime Session events

4e307ba

Update batch.ts

796f6d4

Fix #3255

4c45285

Merge pull request #3278 from harryo/bugfix/error-with-referrer

75009f7

Fix #3255

Merge pull request #3275 from zeroCoder1/master

f166a01

Enhance Batch Processing by Reusing Existing Event Handling Logic

Merge pull request #3274 from harryo/master

bf9a069

Fix duplicate key errors

feat: add CORS headers to any value of COLLECT_API_ENDPOINT in additi…

0d153a2

…on to /api/* endpoints Signed-off-by: Louis Vallat <[email protected]>

Merge pull request #3282 from LouisVallat/dev

3f00d88

add CORS headers to any value of COLLECT_API_ENDPOINT in addition to /api/* endpoints

Refactored batch route.

a8835f3

Removed css rule. Fixes #3272

05db1a8

Added SKIP_DB_MIGRATION var.

9a87442

Allow populating event's createdAt on the send endpoint

30b2879

Added timestamp property to payload.

65f18d1

Merge branch 'dev' into allowCreatedDate

f3ad9a3

Merge pull request #3157 from DavidVentura/allowCreatedDate

0a5a79e

Allow populating event's createdAt on the send endpoint

Updated salt methods.

925c756

Added check for do not track to tracker.

cb7eef2

Bump version 2.17.0.

c52774c

Merge branch 'dev' of https://github.com/umami-software/umami into dev

cfc3662

fix unique key prop error on forms

72ac97c

Make journey report steps optional

51f2a1c

Merge pull request #3292 from Maxime-J/journey-report-fix

21a1487

Fix journey report

update cypress tests, update zod validation error messaging to UI

b1901c7

Merge branch 'dev' of https://github.com/umami-software/umami into dev

3c1ea69

Added more paid ad params. Closes #3270

1b21f26

Added decoding to URL elements.

833de1a

Fixed group referrers count. Closes #3257

97c687f

mikecao merged commit 36c4645 into master Mar 8, 2025
11 checks passed

mikecao deleted the analytics branch March 8, 2025 05:23

greptile-apps bot reviewed Mar 8, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v2.17.0 #3294

v2.17.0 #3294

mikecao commented Mar 8, 2025

vercel bot commented Mar 8, 2025

greptile-apps bot left a comment

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

greptile-apps bot Mar 8, 2025

		"plugin:@typescript-eslint/eslint-recommended",
		"plugin:@typescript-eslint/recommended",

	created_at: getUTCString(createdAt),
	created_at: createdAt ? getUTCString(createdAt) : null,

		@@ -42,6 +43,7 @@ async function relationalQuery(data: {
		numberValue: a.dataType === DATA_TYPE.number ? a.value : null,
		dateValue: a.dataType === DATA_TYPE.date ? new Date(a.value) : null,

		const dnt = doNotTrack \|\| ndnt \|\| msdnt;
		return dnt === 1 \|\| dnt === '1' \|\| dnt === 'yes';

v2.17.0 #3294

v2.17.0 #3294

Conversation

mikecao commented Mar 8, 2025

vercel bot commented Mar 8, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment

greptile-apps bot Mar 8, 2025

Choose a reason for hiding this comment