-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting custom data on autotracked pageviews via data attribute on script element #2436
base: master
Are you sure you want to change the base?
Conversation
@ewen-lbh is attempting to deploy a commit to the umami-software Team on Vercel. A member of the Team first needs to authorize it. |
I added a way to show those custom fields on a website's dashboard. I also excluded pageview custom data from the custom data tab, since it doesn't make much sense and would pollute that tab with lots of events. For now you can add these custom data tables on the dashboard via the URL: I'll add a selector in the UI but it requires much more changes |
for custom pageview data, see umami-software/umami#2436
very cool feature, will this be merged soon? |
@timomayer if you want to use it right away, I've been using my fork in production for a few weeks now with no issues. The annoying thing is that there's nothing in the UI yet to actually choose what custom properties to show, you have to pass them via the query parameter. And also there are some places where you would expect custom properties to show up (e.g. on reports, etc.) but they only appear on the dashboard for now, and you also can't filter by a custom property's value. It's rudimentary but this is still better than Plausible, that outright denies access to this feature on self-hosted instances. |
…s on script element
Since we're on the script element, no need to namespace the attribute with "umami", using data-event-* is enough
… Array#from instead See bublejs/buble#131
3aebe92
to
88ba523
Compare
88ba523
to
faf1fb8
Compare
PRs are usually made against the dev branch. You are doing it against the master branch directly, if I am not mistaken, despite it being the default branch you should change your PR against dev. |
Any update? |
This would allow setting custom data, like Plausible allows with what they call "Custom Properties".
This is very useful to track how much people are on e.g. a version, how much people use the dark theme, how much pageviews are from logged-in users, etc.
An example of what it looks like in the dashboard: