Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove golangci-lint mode #13

Merged
merged 3 commits into from
Dec 17, 2024

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 17, 2024

The golangci-lint will not be require anymore, because golangci-lint will be compatible with SuggestedFix.

Related to golangci/golangci-lint#5232

@ldez ldez force-pushed the feat/remove-golancgi-lint-mode branch from 2c1da3f to b33cbe5 Compare December 17, 2024 00:17
Copy link
Contributor

@robinknaapen robinknaapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM, love to see the improvement made in golangci-lint. Great effort, thanks @ldez

.github/workflows/go.yaml Outdated Show resolved Hide resolved
@ldez ldez marked this pull request as ready for review December 17, 2024 12:31
@robinknaapen robinknaapen merged commit 3d7a6d9 into ultraware:master Dec 17, 2024
1 check passed
@ldez ldez deleted the feat/remove-golancgi-lint-mode branch December 17, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants