-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tp2000 1471 task workflow #1298
Draft
paulpepper-trade
wants to merge
12
commits into
master
Choose a base branch
from
TP2000-1471--task-workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,123
−301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename UserAssignment model to TaskAssignee * Add TaskCategory and TaskProgressState models * Add parent_task field to Task model * Add creator field to Task model * Add TaskLog model * Don't require that tasks have a workbasket * Make progress_state a required field on Task model * Order task category by name and display progress state by value * Remove Task prefix from Category and ProgressState models * Remove workflow app
* Register Category model in admin site * Register ProgressState in admin site * Register TaskAssignee in admin site * Register Task model in admin site
* Add initial TaskCreate view & form * Add initial Task detail view * Add initial Task edit form & view * Add initial Task delete view & form * Add initial Task list view * Try pre_save signals for TaskLog creation * Tidy templates * Allow Task deletion * Register TaskLog model in admin * Add test for TaskLog creation * Rename user group in conftest * Set up pre_save signal for TaskAssignee to create TaskLog entries * Persist TaskLog entries after Task deletion * Add mixins to override Manager and QuerySet methods for pre_save signal handling * Fix Task delete view * Move WithSignalManagerMixin and WithSignalQuerysetMixin to common/models/mixins * Set initial pagination limit for TaskListView
* create 'subtask create form' with predetermined parent * add test to check that SubtaskCreateForm.save adds correct parent task when creating subtask
… and workflow task items (#1321) * Split models file and add stubbed queue support. * Removed queue from base class; Create TaskItem using TaskItemTemplate position * Amend TaskItem.position exception error message * Override QueueItem metaclass to enforce queue field on conrete subclasses * Export queue-related models from tasks * Implement Queue instance methods using new get_related_objects util method * Implement QueueItem instance methods * Add Queue.get_items() and add return type annotations * Add concrete test-only models for Queue and QueueItem * Add queue tests * Add queue and item tests * Refactor TableLock into a decorator and context manager * Override QueueItem's model manager create method to set queue positions on behalf of subclasses * Amend Queue and QueueItem tests * Docstring updates. * Support only a single reverse FK relationship to QueueItem for queue instances * Support default State instance on ProgressState and Task.progress_state * Remove redundant model manager. Add task and task template util methods. * Add workflow unit tests. * Rely on Task.progress_state default in WB assign users view --------- Co-authored-by: Dale Cannon <[email protected]>
* Implement prototype TaskWorkflowTemplate detail view * Rename workflow template jinja template * Add TaskWorkflowTemplateDetailView test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP2000-1471 Task workflows
Why
Discovery and business analysis work has uncovered a core, and probably reasonably stable, set of behaviours around TAP task and workflow integration. Implementing a kernel of that behaviour in software as a type of minimum viable product has advantages including:
What
This PR implements:
Checklist