Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agenda for March #40

Merged
merged 12 commits into from
Feb 20, 2024
Merged

Agenda for March #40

merged 12 commits into from
Feb 20, 2024

Conversation

harisood
Copy link
Member

Adding the timings for March - will populate as we get sessions suggested!

@harisood harisood requested a review from manics February 13, 2024 16:45
@harisood
Copy link
Member Author

@manics I'm getting bored... is there something I'm doing wrong?

@manics
Copy link
Member

manics commented Feb 14, 2024

From https://github.com/uk-tre/website/actions/runs/7904379187/job/21574507435?pr=40

(events/wg_workshops/2023-12-05-december-meeting/index: line  130) broken    https://crick.zoom.us/meeting/register/u5cuceGhrzMrH9EPh3tFZiRoPPxrsN277MZJ - 404 Client Error: Not Found for url: https://crick.zoom.us/meeting/register/u5cuceGhrzMrH9EPh3tFZiRoPPxrsN277MZJ
(events/wg_workshops/2023-12-05-december-meeting/index: line  110) broken    https://crick.zoom.us/meeting/register/u5csc-iqpjguGdUmSzXqcvhC2c1MgX6cEh0q - 404 Client Error: Not Found for url: https://crick.zoom.us/meeting/register/u5csc-iqpjguGdUmSzXqcvhC2c1MgX6cEh0q
(events/wg_workshops/2023-12-05-december-meeting/index: line   90) broken    https://crick.zoom.us/meeting/register/u5Mtf-yoqzooH9zP9q2fzeQ1qMM_Jh_yzC6s - 404 Client Error: Not Found for url: https://crick.zoom.us/meeting/register/u5Mtf-yoqzooH9zP9q2fzeQ1qMM_Jh_yzC6s

manics
manics reviewed Feb 14, 2024
View reviewed changes
.../events/wg_workshops/2023-03-29-march-meeting/project-systematic-data-risk-classification.md Outdated
@@ -21,7 +21,7 @@ _Chair: Will Crocombe (RISG Consulting)_
- Dropping down tiers, things become easier. Turing paper on this - Sheffield used this as the basis of their system for assessing risk.
- [Alan Turing Institute paper](https://arxiv.org/pdf/1908.08737.pdf)
- Importance of agreed risk classification with federation, and agreement on risk appetite
- [NIST RMF](https://csrc.nist.gov/projects/risk-management/about-rmf)
- NIST RMF: `<https://csrc.nist.gov/projects/risk-management/about-rmf>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look right, what's the linkcheck error?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was saying Gateway timeout

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's just faiiling in the automated link,check can you revert this and add it to the list of ignored links instead? It's working fine for me in a browser.

manics
manics reviewed Feb 14, 2024
View reviewed changes
docs/events/wg_workshops/2023-12-05-december-meeting/discussion-tre-federation.md Outdated
@@ -71,7 +71,7 @@ Next steps include setting up a high-level federation working group, and use thi
- So do we need a concept beyond a TRE? Do we need a new phrase / name?
- TREs that are designed from the outset to federate?
- DataSHIELD has been around for 10 years - not complete but huge open source community of researchers.
- And there is this -> https://www.hpe.com/us/en/hpe-swarm-learning.html
`- And there is this -> https://www.hpe.com/us/en/solutions/ai-artificial-intelligence.html`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will turn this into monospace text, probably not what you intended!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was lol, so the link is still there but there aren't redirect issues

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As with my other comment I think it's better to keep these links clickable and add them to an ignored list.

@harisood
Copy link
Member Author

ugh ok cool i thought all i had to do was look at the link above where the error was logged not search for broken ones... I call that a design issue!!

@manics
Copy link
Member

manics commented Feb 14, 2024

You can disable checking of individual links in

website/docs/conf.py

Lines 44 to 55 in 651830f

# -- Link checker configuration
linkcheck_ignore = [
# GitHub CI linkchecker seems to be blocked
r"https://www.turing.ac.uk/.*"
]
# These pages use in-page JavaScript anchors which aren't seen by the link checker
linkcheck_anchors_ignore_for_url = [
r"https://www\.swansea\.ac\.uk/the-university/location/",
r"https://arewemeetingyet\.com/.+",
]

@harisood
Copy link
Member Author

Probs helpful to make sure links are clean j need to remember how to catch them!

Davsarper
Davsarper previously approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@Davsarper Davsarper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harisood harisood merged commit bdaf0c6 into main Feb 20, 2024
5 checks passed
@manics manics deleted the march-event-details branch May 16, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manics manics manics left review comments

@Davsarper Davsarper Davsarper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harisood @manics @Davsarper