-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Initial about us restructure #21
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Davsarper <[email protected]>
I haven't reviewed this yet, but if we're moving pages we should add in some redirects to avoid breaking incoming links. |
How important tis that/easy to fix? I don't think there are many external places we have links stored to atm, so not too fussed by it. Alternatiely a 404 catch all that redirects to the home page would probs be fine |
We don't know which third parties are publically or privately linking to us, and I think it's good practice to avoid breaking links without good reason. There are extensions to help with redirects, e.g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change being the slack I am ready to approve, yet I think we should resolve the links redirect conversation.
docs/about/contact.md
Outdated
@@ -0,0 +1,3 @@ | |||
# Our contact information | |||
|
|||
To be added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this be a different set of contact details from the Slack and mailing lists?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also including the uktrecommunity email
docs/about/index.md
Outdated
|
||
## [](contact.md) | ||
|
||
The different ways you can get involved with the community! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this description right? "contact.md" just implies getting in touch, whereas it sounds like this is more about getting involved? So maybe "join-us.md"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! We are suggesting having a more in depth get involved elsewhere - so maybe a wording change above?
Co-authored-by: Simon Li <[email protected]>
Co-authored-by: Simon Li <[email protected]>
Co-authored-by: Simon Li <[email protected]>
Co-authored-by: harisood <[email protected]>
@manics are you happy to merge this and add redirects as a separate issue to be addressed, or should we include it within this PR? (I think I know what the right answer is but I'm asking anyway...) |
Can we do it in this PR since it affects the live site? If you don't want to use one of the plugins that creates automatic redirects you could recreate the old pages and include a link to the new pages instead, or if there's no replacement link to the github file pinned by commit. |
Uploading file for community proposal as an independent PR separate from #21
I have converted to draft, most content will be copied over to the final website structure and this specific PR probably closed |
This is a restructure that will allow us to action #20