gen upgrade base implementation
#552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the argument order should be It may be simpler to not return the new seed. This could be achieved via |
amatgil
force-pushed
the
mgen_proper
branch
5 times, most recently
from
30e364d
to
e3f6264
Compare
|
Argument order has been decided on It should be ready to merge |
amatgil
force-pushed
the
mgen_proper
branch
from
e3f6264
to
dd5d717
Compare
kaikalii
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
gento take a shape and a seed and return an array of that shape full of random numbers. There are still some questions to answer, though