Upgrade term_size version to the latest beta v1.0.0-beta.2 #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axbannaz
force-pushed
the
update_term_size
branch
from
1dd243b
to
7761db4
Compare
axbannaz
changed the title
axbannaz
changed the title
which fixes build and test on Windows 10/11 Arm64
axbannaz
force-pushed
the
update_term_size
branch
from
7761db4
to
ede575b
Compare
axbannaz
changed the title
… clippy::needless_borrows_for_generic_args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which fixes build and test on Windows 10/11 Arm64
the issue is
winapicrate that comes in as a dependency on windows via term_size crate.1.0.0-beta1 version of term_size brings in winapi 0.2.8
updating to exactly 1.0.0-beta.2 removes the dependencies that require winapi 0.2.8.. which fixes the issue with building windows 11 arm64
clippy::needless_borrowsdoes not exist in newer rust clippy.. it suggestedclippy::needless_borrows_for_generic_args