Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prompt user to enable notebook.formatOnCellExecution #11

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thehappycheese
Copy link
Contributor

@thehappycheese thehappycheese commented Jan 1, 2024

This change prompts the user to enable the vscode built in setting notebook.formatOnCellExecution when switching focus to a notebook which is configured to use the 'uiua' language
(see experimental kernel https://github.com/thehappycheese/uiua_kernel)

Given that the kernel is experimental, it may be too early to accept this PR

I am now also wondering:

  • The extension should remember if the user refuses, so it can stop prompting
  • Maybe there should also be a prompt to enable editor.formatOnSave when editing regular .ua files?
  • It would be preferable to only enable this setting for uiua notebooks. Currently changing notebook.formatOnCellExecution or editor.formatOnSave wold apply to all notebooks. I figure this is fine, as long as it is set at the workspace level... but still it is undesirable behavior.
    • I tried to find a way to make this extension listen for notebook cell execution events, but I couldn't find one yet.

This change prompts the user to enable the vscode built in setting notebook.formatOnCellExecution when switching focus to a notebook which is configured to use the 'uiua' language (see https://github.com/thehappycheese/uiua_kernel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant