Allow default behaviour in stopEvent/ignoreMutation overrides #5590
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1587216 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
❌ Deploy Preview for tiptap-embed failed. Why did it fail? →
|
nperez0111
reviewed
Oct 25, 2024
| @@ -119,7 +119,10 @@ export class NodeView< | |||
| } | |||
|
|
|||
| if (typeof this.options.stopEvent === 'function') { | |||
| return this.options.stopEvent({ event }) | |||
| const shouldStopEvent = return this.options.stopEvent({ event }) | |||
There was a problem hiding this comment.
This syntax looks wrong
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
In my case, I needed to override
stopEvent, but only for a specific case. Otherwise I'd like for it to have a default behaviour. To do this, I'd have to recreate all the checks from defaultstopEventin my override. This PR addresses this inconvenience.Implementation Approach
stopEventignores override only if you explicitly return anull. This should minimize a breaking change for existing usages.Testing Done
Verification Steps
Additional Notes
Checklist
Related Issues
#257