Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting indented functions in test cells to doctests #869

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

chrispyles
Copy link
Member

Closes #840

@chrispyles chrispyles added the bug Something isn't working label Oct 25, 2024
@chrispyles chrispyles added this to the v6.0.0 milestone Oct 25, 2024
@chrispyles chrispyles enabled auto-merge (squash) October 25, 2024 03:39
@chrispyles chrispyles merged commit 14ede16 into ucbds-infra:beta Oct 25, 2024
7 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11511446106

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 83.013%

Changes Missing Coverage Covered Lines Changed/Added Lines %
otter/assign/utils.py 1 2 50.0%
Totals Coverage Status
Change from base Build 11511332001: -0.02%
Covered Lines: 3763
Relevant Lines: 4533

💛 - Coveralls

chrispyles added a commit that referenced this pull request Oct 26, 2024
* remove nbconvert < 6 compat patches

* throw error on nbconvert<6

* convert pdf via html exporter to use nbconvert webpdf exporter

* removed pdfkit, wkhtmltopdf, cleanup

* undo adding nbconvert[webpdf] to grading container image

* changelog

* add depencies for exporting pdfs via html to grading image

* enable pdf via html in grading containers

* install only chromium

* remove nbconvert < 6 compat patches

* throw error on nbconvert<6

* convert pdf via html exporter to use nbconvert webpdf exporter

* removed pdfkit, wkhtmltopdf, cleanup

* undo adding nbconvert[webpdf] to grading container image

* changelog

* add depencies for exporting pdfs via html to grading image

* enable pdf via html in grading containers

* install only chromium

* use poetry and pyproject.toml for packaging

* update CI to run Docker tests weekly instead of on every push/PR

* extras poetry

* docs

* py3.12 default, migrate to extras for dep mgmt, slim down grading envs

* update proj03 example

* Update .readthedocs.yml

* catch chromium error from nbconvert

* changelog

* combine export and grading extras

* update run-docker-tests.yml

* debugging beta branch not reusing cached docker images in tests

* update .dockerignore

* add matplotlib and numpy to grade test requirements.txt

* Handle empty assignment configs in Otter Assign

Closes #795

* Clean up JupyterLite support and remove import_or_raise per #511

* Removed variables key of assignment config in favor of generate.serialized_variables in Otter Assign per #628

* Update Otter Assign to add cell metadata so that questions with no check cell have their tests run after the last solution cell per #798

* type hints for functions in otter/assign

* cleanup

* upgrade setup-buildx-action

* Updated Otter Assign to strip type annotations from generated test code per #796

* Updated Otter Grade Docker image to create an empty submission_metadata.json file in the grading image to prevent plugins from erroring per #811

* Otter Grade: Added Progress Monitoring to Queue

- When an instance of ``multiprocessing.Queue`` is passed to
grade/__init_.py::main, progress messages are written to the
``multiprocessing.Queue` via custom QueueLoggingHandler

* Otter Grade: Cleaned Up Progress Monitoring

* Otter Grade: Clean Up Progress Monitoring

* Otter Grade: Progress Monitoring CHANGELOG updated

* Update CHANGELOG.md

* Update utils.py

* Format code with black and isort (#839)

* add black to pyproject.toml

* reformat files with black

* add isort for import sorting

* reformat files with isort

* restore test file formatting

* fix exclusions and make otter generate render templates correctly

* add workflow for checking formatting

* use different poetry setup action

* pin fica>=0.4.1

* fixing lsp complaints

* fix args and kwargs type hints

* add student_files to otter assign (#852)

* Add pip install cell to Colab notebooks (#862)

* Add ability to ignore .OTTER_LOG to Notebook.export and Otter Assign (#863)

* add ability to ignore .OTTER_LOG to Notebook.export and Otter Assign

* typo

* Fix/add support for all_or_nothing test file config (#865)

* Add more tests for otter.test_files (#866)

* update deps

* update cache key

* debugging failed builds

* add nb_conda_kernels

* add note about code formatting to CONTRIBUTING.md

* go back an additional frame in Notebook.check for py3.13 for some reason :(

* use matrix to cover supported python versions

* add coveralls parallel builds for matrix and pin py3.9 for docker tests

* docs for all_or_nothing

* Auto-ignore test fn calls in assign exception-based test cells (#867)

* Add addl packages to otter --version (#868)

* add addl packages to otter --version

* add addl packages to otter --version

* remake poetry.lock

* Fix converting indented functions in test cells to doctests (#869)

* add question structure to otter assign docs

* remove unnecessary passage

---------

Co-authored-by: sean-morris <[email protected]>
@chrispyles chrispyles deleted the fix-840 branch December 31, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants