Don't send a certificate for non-blob-storage image downloads #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pykello
force-pushed
the
pykello/image_cert
branch
from
71ee47a
to
b8764e8
Compare
enescakir
reviewed
May 12, 2024
pykello
force-pushed
the
pykello/image_cert
branch
from
b8764e8
to
636b77c
Compare
enescakir
approved these changes
May 13, 2024
Non-blob-storage images don't require a certificate. This caused problems in the E2E tests where `ubicloud_images_blob_storage_certs` wasn't set.
pykello
force-pushed
the
pykello/image_cert
branch
from
636b77c
to
11b9689
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Non-blob-storage images don't require a certificate. This caused problems in the E2E tests where
ubicloud_images_blob_storage_certswasn't set.