Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making it possible to specify connect and header timeouts on registry backends #286

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wk8
Copy link

@wk8 wk8 commented Oct 20, 2020

With unit tests.

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2020

CLA assistant check
All committers have signed the CLA.

@wk8 wk8 force-pushed the jrouge/registry_response_header_timeout branch 4 times, most recently from c71524b to 9dbee44 Compare October 21, 2020 21:49
@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (e435b83) 64.80% compared to head (aa51557) 64.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   64.80%   64.89%   +0.09%     
==========================================
  Files         186      186              
  Lines        7822     7831       +9     
==========================================
+ Hits         5069     5082      +13     
+ Misses       1999     1996       -3     
+ Partials      754      753       -1     
Impacted Files Coverage Δ
lib/backend/registrybackend/blobclient.go 75.00% <100.00%> (+3.12%) ⬆️
lib/backend/registrybackend/config.go 100.00% <100.00%> (ø)
lib/backend/registrybackend/tagclient.go 63.76% <100.00%> (+5.79%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wk8 wk8 force-pushed the jrouge/registry_response_header_timeout branch 2 times, most recently from b08df8b to 5424c46 Compare October 21, 2020 22:29
@wk8 wk8 force-pushed the jrouge/registry_response_header_timeout branch from 5424c46 to aa51557 Compare October 21, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants