Making lib/backend/client.getFactory public #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 64.80% 64.90% +0.10%
==========================================
Files 186 186
Lines 7822 7822
==========================================
+ Hits 5069 5077 +8
+ Misses 1999 1994 -5
+ Partials 754 751 -3
☔ View full report in Codecov by Sentry. |
Mainly to allow writing "wrapper" custom backends, see eg uber#278 (comment) Signed-off-by: Jean Rouge <[email protected]>
wk8
force-pushed
the
jrouge/public_client_factory
branch
from
bc73e63
to
d4b0fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to allow writing "wrapper" custom backends, see eg
#278 (comment)