[DO NOT REVIEW ] Append rules that match the glob in neal.json

src/core/driver/driver.ml

@@ -105,7 +105,7 @@ let scope_matches { includes; ignores } file =
 exception Break of Neal.Rule.ruleset list
 let collect_rules file rules = function
   | (`Global, rs) -> rs @ rules
-  | (`Scoped scope, rs) when scope_matches scope file -> raise (Break rs)
+  | (`Scoped scope, rs) when scope_matches scope file -> rs @ rules
   | _ -> rules
 
 let visitor (module P : Provider.PROVIDER) reporters file source rules absyn =

tests/integration/input/glob/test.test

@@ -1,5 +1,8 @@
 // RUN: %not %neal %p | %check
 
-// CHECK-NEXT: error: Must use visibility = PRIVATE instead.
-// CHECK-NEXT: error: Call bar instead
+// Make sure that there are only 2 errors emitted
+// RUN: %not %neal %p | test $(wc -l) -eq 3
+
+// CHECK: error: Must use visibility = PRIVATE instead.
+// CHECK: error: Call bar instead
 // CHECK-NOT: .*

tests/integration/multiple_configurations/apps/Application.swift

@@ -0,0 +1,14 @@
+
+
+func main() {
+  let value = convertToInteger(0.123)
+    DispatchQueue.main.async {
+      let view = UIView()
+      view.backgroundColor = .red
+  }
+}
+
+
+func convertToInteger(x: Double) -> Int {
+  return x as! Int
+}

tests/integration/multiple_configurations/libraries/Libraries.swift

@@ -0,0 +1,12 @@
+import UIKit
+import Foundation
+
+func getDispatchQueue() {
+       let dispatchQueue = Foundation.DispatchQueue()
+}
+
+func setBlackColor(view: UIView) {
+  view.backgroundColor = .white
+}
+
+

tests/integration/multiple_configurations/lit.local.cfg

@@ -0,0 +1,3 @@
+# vi: ft=python
+
+config.suffixes = ['.test']

tests/integration/multiple_configurations/multiple_configurations.test

@@ -0,0 +1,8 @@
+// RUN: %not %neal %p | %check
+
+// Make sure that there are only 3 errors emitted
+// RUN: %not %neal %p | test $(wc -l) -eq 3
+
+// CHECK-L:apps/Application.swift:12: error: Force-casting can easily crash the app, therefore, not allowed. (NoForceCasting)
+// CHECK-L:libraries/Libraries.swift:5: error: Use `PresidioFoundation.DispatchQueue` instead of GCD to allow unit testing. (GCD)
+// CHECK-L:libraries/Libraries.swift:9: error: Dont use default UIColors (UIColors)

tests/integration/multiple_configurations/neal.json

@@ -0,0 +1,31 @@
+{
+  "rule-map": [
+    {
+      "name": "APPLICATION_CONFIG",
+      "glob": [
+        "apps/.*"
+      ],
+      "rules": [
+        "./rules/application.rules"
+      ]
+    },
+    {
+      "name": "LIBRARY_CONFIG",
+      "glob": [
+        "libraries/.*"
+      ],
+      "rules": [
+        "./rules/libraries.rules"
+      ]
+    },
+    {
+      "name": "COMMON_RULES",
+      "glob": [
+        ".*"
+      ],
+      "rules": [
+        "./rules/common.rules"
+      ]
+    }
+  ]
+}

tests/integration/multiple_configurations/rules/application.rules

@@ -0,0 +1,5 @@
+rule NoForceCasting {
+  Swift::TypeCastingExpresion where Operator == "as!" {
+    fail("Force-casting can easily crash the app, therefore, not allowed.")
+  }
+}

tests/integration/multiple_configurations/rules/common.rules

@@ -0,0 +1,7 @@
+
+rule GCD {
+  Swift::ExplicitMemberExpression where Object == "Foundation" && Member == "DispatchQueue" {
+    fail("Use `PresidioFoundation.DispatchQueue` instead of GCD to allow unit testing.")
+  }
+}
+

tests/integration/multiple_configurations/rules/libraries.rules

@@ -0,0 +1,5 @@
+rule UIColors {
+  Swift::ImplicitMemberExpression where match(Property, /\b(white|black|lightGray|gray|clear|darkGray|orange|clear|yellow|blue|red)$/) {
+    fail("Dont use default UIColors")
+  }
+}