fix gradle exec issue. #127
Conversation
WalkthroughThe pull request modifies the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
all/build.gradle.kts (1)
50-53: Good transition to providers.exec, but path handling needs improvement.The transition to
providers.execis a good practice for better Gradle integration. However, the path concatenation could be improved.Consider using
project.projectDir.resolve()for more reliable path handling:- args = listOf(project.projectDir.path + "/../tool/rename_podfile.sh") + args = listOf(project.projectDir.resolve("../tool/rename_podfile.sh").toString())
| providers.exec { | ||
| executable = "sh" | ||
| args = listOf("./tool/rename_podfile.sh") | ||
| } | ||
| args = listOf(project.projectDir.path + "/../tool/rename_podfile.sh") | ||
| }.standardOutput.asText.get() | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Add error handling for script execution.
The current implementation doesn't handle potential errors from script execution.
Consider adding error handling:
tasks.podPublishXCFramework {
doLast {
- providers.exec {
- executable = "sh"
- args = listOf(project.projectDir.path + "/../tool/rename_podfile.sh")
- }.standardOutput.asText.get()
+ val scriptFile = project.projectDir.resolve("../tool/rename_podfile.sh")
+ if (!scriptFile.exists()) {
+ throw GradleException("Script file not found: ${scriptFile.absolutePath}")
+ }
+
+ val result = providers.exec {
+ executable = "sh"
+ args = listOf(scriptFile.toString())
+ }
+
+ try {
+ result.standardOutput.asText.get()
+ } catch (e: Exception) {
+ throw GradleException("Failed to execute rename_podfile.sh: ${e.message}")
+ }
}
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| providers.exec { | |
| executable = "sh" | |
| args = listOf("./tool/rename_podfile.sh") | |
| } | |
| args = listOf(project.projectDir.path + "/../tool/rename_podfile.sh") | |
| }.standardOutput.asText.get() | |
| } | |
| } | |
| } | |
| providers.exec { | |
| val scriptFile = project.projectDir.resolve("../tool/rename_podfile.sh") | |
| if (!scriptFile.exists()) { | |
| throw GradleException("Script file not found: ${scriptFile.absolutePath}") | |
| } | |
| val result = providers.exec { | |
| executable = "sh" | |
| args = listOf(scriptFile.toString()) | |
| } | |
| try { | |
| result.standardOutput.asText.get() | |
| } catch (e: Exception) { | |
| throw GradleException("Failed to execute rename_podfile.sh: ${e.message}") | |
| } | |
| } | |
| } | |
| } |
Summary by CodeRabbit