-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Radio Thmanyah as Podcast Catcher #568
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,3 +3,5 @@ node_modules/ | |
package-lock.json | ||
*.tgz | ||
*.log | ||
.prettierignore | ||
.vscode |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -45,6 +45,7 @@ user_agent_parsers: | |
- regex: 'ArcGIS\.Runtime\.(Qt)\.(\d+)\.(\d+)(?:\.(\d+)|)' | ||
family_replacement: 'ArcGIS Runtime SDK for $1' | ||
|
||
# | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ? |
||
# CFNetwork Podcast catcher Applications | ||
- regex: '^(Luminary)[Stage]+/(\d+) CFNetwork' | ||
- regex: '(ESPN)[%20| ]+Radio/(\d+)\.(\d+)\.(\d+) CFNetwork' | ||
|
@@ -68,6 +69,17 @@ user_agent_parsers: | |
family_replacement: 'AudioBoom' | ||
- regex: ' (Rivo) RHYTHM' | ||
|
||
# Radio Thmanyah Podcast Catcher | ||
- regex: '(Radio Thmanyah)/(\d+)\.(\d+)\.(\d+)' | ||
family_replacement: 'Radio Thmanyah' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line not needed, as you use a capture group with the same value |
||
- regex: '(Radio Thmanyah ar)/(\d+)\.(\d+)\.(\d+)' | ||
family_replacement: 'راديو ثمانية' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. For consistency, can the family be written in non-utf8 characters? (i.e. why do we need the arabic distinction) |
||
- regex: '(Radio Thmanyah Android)/(\d+)\.(\d+)\.(\d+)' | ||
family_replacement: 'Radio Thmanyah Android' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line not needed, as you use a capture group with the same value |
||
- regex: '(Radio Thmanyah iOS)/(\d+)\.(\d+)\.(\d+)' | ||
family_replacement: 'Radio Thmanyah iOS' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. line not needed, as you use a capture group with the same value |
||
|
||
|
||
# @note: iOS / OSX Applications | ||
- regex: '(CFNetwork)(?:/(\d+)\.(\d+)(?:\.(\d+)|)|)' | ||
family_replacement: 'CFNetwork' | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unsure about that one,
.vscode.
makes sense though