Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds/core/tty: tty command #2989

Merged
merged 2 commits into from
May 30, 2024
Merged

cmds/core/tty: tty command #2989

merged 2 commits into from
May 30, 2024

Conversation

binjip978
Copy link
Contributor

No description provided.

cmds/core/tty/tty.go Outdated Show resolved Hide resolved
cmds/core/tty/tty.go Show resolved Hide resolved
cmds/core/tty/tty.go Show resolved Hide resolved
@rminnich rminnich added the Awaiting author Waiting for new changes or feedback for author. label May 25, 2024
Signed-off-by: Siarhiej Siemianczuk <[email protected]>
Copy link

codecov bot commented May 25, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 56.05%. Comparing base (d92d00a) to head (01c8f36).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   55.84%   56.05%   +0.20%     
==========================================
  Files         517      518       +1     
  Lines       31326    31348      +22     
==========================================
+ Hits        17495    17571      +76     
+ Misses      13831    13777      -54     
Flag Coverage Δ
.-amd64 90.69% <ø> (ø)
cmds/...-amd64 45.53% <68.18%> (+0.03%) ⬆️
integration/generic-tests/...-amd64 19.80% <ø> (ø)
integration/generic-tests/...-arm 11.69% <ø> (ø)
integration/generic-tests/...-arm64 23.96% <ø> (ø)
integration/gotests/...-amd64 61.00% <59.09%> (+0.38%) ⬆️
integration/gotests/...-arm 61.63% <59.09%> (-0.17%) ⬇️
integration/gotests/...-arm64 62.01% <59.09%> (-0.01%) ⬇️
pkg/...-amd64 56.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 62.03% <68.18%> (+0.24%) ⬆️
cmds/exp 30.54% <ø> (ø)

@binjip978 binjip978 added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels May 25, 2024
@binjip978 binjip978 requested a review from rminnich May 25, 2024 04:50
@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels May 30, 2024
@binjip978 binjip978 merged commit b5333f0 into u-root:main May 30, 2024
36 of 37 checks passed
@binjip978 binjip978 deleted the tty branch May 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting author Waiting for new changes or feedback for author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants