Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spidev: process arguments for raw command #2973

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Conversation

rminnich
Copy link
Member

for the raw command, for each arg, dump arg size bytes to stdout.

Ryan, feel free to tell me this should be done differently/better :-)

I just did not want to lose these changes.

@rminnich rminnich added the Awaiting reviewer Waiting for a reviewer. label Apr 25, 2024
@rminnich rminnich requested a review from rjoleary April 25, 2024 16:52
10000TB
10000TB previously approved these changes May 15, 2024
cmds/fwtools/spidev/spidev_linux.go Outdated Show resolved Hide resolved
@10000TB
Copy link
Member

10000TB commented May 15, 2024

BTW, not related to this change, but pflag seems to print out an error on spidev --help , which looks weird

xuehaohu@worldpeace:~$ spidev --help
Usage of spidev:
  -D, --device string   spidev device (default "/dev/spidev0.0")
  -s, --speed uint32    max speed in Hz (default 500000)
2024/05/15 13:04:58 Error: pflag: help requested
xuehaohu@worldpeace:~$

@10000TB 10000TB added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels May 15, 2024
@rminnich
Copy link
Member Author

Hi, I cleaned this up a bit, including getting rid of spf13 and the spew from the flag package. PTAL.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 57.98%. Comparing base (5608ea9) to head (af22aa8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2973      +/-   ##
==========================================
- Coverage   57.98%   57.98%   -0.01%     
==========================================
  Files         531      531              
  Lines       32934    32948      +14     
==========================================
+ Hits        19097    19104       +7     
- Misses      13837    13844       +7     
Flag Coverage Δ
.-amd64 90.69% <ø> (ø)
cmds/...-amd64 46.76% <72.00%> (-0.02%) ⬇️
integration/generic-tests/...-amd64 19.80% <ø> (ø)
integration/generic-tests/...-arm 11.69% <ø> (ø)
integration/generic-tests/...-arm64 23.96% <ø> (ø)
integration/gotests/...-amd64 61.37% <ø> (-0.01%) ⬇️
integration/gotests/...-arm 62.54% <ø> (+0.15%) ⬆️
integration/gotests/...-arm64 62.63% <ø> (+<0.01%) ⬆️
pkg/...-amd64 58.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
everything 64.03% <72.00%> (-0.01%) ⬇️
cmds/exp 30.54% <ø> (ø)

for the raw command, for each arg, dump arg size bytes to
stdout.

Signed-off-by: Ronald G. Minnich <[email protected]>
@rminnich rminnich added Awaiting reviewer Waiting for a reviewer. and removed Awaiting author Waiting for new changes or feedback for author. labels Jun 20, 2024
@rminnich rminnich merged commit f3569d6 into u-root:main Jun 21, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants