Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/batch backfill v18 #70

Open
wants to merge 4 commits into
base: node-18-upgrade
Choose a base branch
from

Conversation

DavidWeiss2
Copy link

Change Summary

The current batch mechanism is failing on Firestore big collections with a function crash.
This PR fixing this issue.

Also on this PR -
Better comments for failing batch (the current one get trimmed when multiple errors)

but for v18

PR Checklist

@DavidWeiss2
Copy link
Author

Saw the conflicts, fixing them.

@jasonbosco jasonbosco mentioned this pull request Dec 23, 2023
1 task
@DavidWeiss2
Copy link
Author

@jasonbosco Conflict resolved

Copy link
Member

@jasonbosco jasonbosco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants