New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-floating-promises] check top-level type assertions (and more) #9043
base: main
Are you sure you want to change the base?
fix(eslint-plugin): [no-floating-promises] check top-level type assertions (and more) #9043
Conversation
Thanks for the PR, @kirkwaiblinger! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
async function test() { | ||
declare const promiseValue: Promise<number>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are just because declare
is not syntactically allowed in that position (it's required to be at top level). Just some hygiene, not relevant to the changes.
code: ` | ||
declare let x: any; | ||
declare const promiseArray: Array<Promise<unknown>>; | ||
x = promiseArray; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surprisingly, assignments without a declaration were not tested for
if (node.type === AST_NODE_TYPES.AwaitExpression) { | ||
// you would think this wouldn't be strictly necessary, since we're | ||
// anyway checking the type of the expression, but, unfortunately TS | ||
// reports the result of `await (promise as Promise<number> & number)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typescript gives a warning
'await' has no effect on the type of this expression.
Lets not include example of those cases for which the ts compiler gives us a warning/error (?)
Minimum repro for the warning , hover over await
keyword in line 2.
}, | ||
{ | ||
code: ` | ||
3 as Promise<number>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a community maintainer, but I'm very much against these tests.
Even, after checking off all the options in the type-checking section, typescript is still giving error on this statement.
Either these tests be removed or should be replaced with valid ts code.
PR Checklist
Overview
Changes implementation from an unhandled promise syntax allowlist to a syntax denylist.