-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split troubleshooting into granular sections #9024
base: main
Are you sure you want to change the base?
docs: split troubleshooting into granular sections #9024
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I'm on the fence of whether this deserves its own page. I think it could be moved to its own section in FAQs.mdx
. Is there anything else we'd want to have here?
I was tempted to include typed linting .js
info, but that's already covered in Typed Linting.
I'm leaning strongly towards this change (moving these two FAQs out) so we can reduce the size of the Troubleshooting portion of the sidebar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth its own page! See also #8955 (comment)... maybe this is an opportunity to throw in an additional sentence or two that plenty of rules will have no effect on js files, but a few will enforce illegal syntax and must be disabled. And type-aware rules actually can work in js files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! Great. +1. I think that'd be an excellent followup to this (I suspect the discussion over how to phrase the .js
recommendations might get long).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/troubleshooting/FAQs.mdx
Outdated
@@ -1,189 +1,166 @@ | |||
--- | |||
id: faqs | |||
title: FAQs | |||
slug: /troubleshooting/ | |||
slug: /troubleshooting/faqs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to break all of our historical links isn't it 😭
Maybe we need error code short URLs to make this easier huehuehue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't with this redirects config! I really hope it doesn't. That'd be a bug if it does.
// in docusaurus.config.mts > redirects
{
from: '/troubleshooting',
to: '/troubleshooting/faqs',
},
But yeah strong +1 to error code short URLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a general comment about the hierarchy. "TSLint" and "Formatting" are "FAQs" but not really "Troubleshooting". This makes me think if it shouldn't look like:
faqs
tslint
formatting
troubleshooting
index
working-with-javascript
typed-linting
index
monorepos
performance
Btw I strongly recommend using faqs/index.mdx
instead of FAQs.mdx
. Makes it easier to look at the hierarchy.
@Josh-Cena that is a fantastic point. I'm now realizing that the "What About ..." pages are the only ones under Troubleshooting that aren't actually "troubleshooting" content... and both get less and less relevant over time. I pushed them down into Users. I also more formally split the FAQs into a page per area (ESLint, frameworks, JS, TS). |
bafe6c8
to
9c8835a
Compare
PERSONALLY I don't love having valuable content on a page that's accessible via an expandable header. I think that either: I personally find all the time that I click the arrow and don't find what i'm looking for - only to realise that I actually wanted to click 10px to the left on the item itself. I hate it, personally! I do this all the time on my phone and I hate it. For example I've done this a few times:
Super clunky UX - I hate it. So I'd suggest adding a "General" item beneath FAQs which allows you to see the "general FAQs". |
PR Checklist
Overview
sidebar.base.js
contents so the sidebar isn't now bigger than before💖