feat(library): add 'type' argument to Release trigger #1783
Conversation
| RegistryPackage(types("published", "updated")), | ||
| Release(types("published", "unpublished")), | ||
| Release(types = listOf("published", "unpublished")), | ||
| RepositoryDispatch(types = listOf("foo", "bar")), | ||
| Schedule(emptyList()), | ||
| Status(types("started")), |
There was a problem hiding this comment.
Looks like lots of triggers have the types argument, so ideally we should add the typed types to all. However, due to time constraints, let me just add it to Release for now.
There was a problem hiding this comment.
As far as I understood all the triggers have that.
So I guess a Trigger base class that provides the property would probably make sense.
There was a problem hiding this comment.
Or maybe not all events currently, but potentially types could be added as the link I provided describes it uniformly for all event triggers and then the doc for the events specifies which types each event supports.
But as long as we do not make an explicit list per event, I'd say we should support it for all so that if types are added on GitHub-side it would also work.
Closes #1781