Make connectionIO syntax available without import #1595
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still wanted? Happy to fix the conflicts it if so |
|
Thanks @bplommer. Sorry this has been lingering for a long time. I think we can close this ticket for now. I'm thinking of transferring doobie to the typelevel github & maven org, which will be a good time to merge the modules as it minimizes confusion. I think we can close this PR for now but leave the issue open. When we've done the necessary work we can implement this change again on top, to avoid having to deal with conflicts. Thanks! |
|
No worries! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires combining the
freeandcoremodules to make Transactor visible from ConnectionOp. I added amacrosmodule so the scala 2 macros would be usable from core.Resolves #1592