Add doc for IOApp#pollingSystem
#4222
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
requested changes
Jan 2, 2025
Comment on lines
+169
to
+170
| * The [[unsafe.PollingSystem]] used by the [[runtime]] which will evaluate the [[IO]] | ||
| * produced by `run`. It is very unlikely that users will need to override this method. |
There was a problem hiding this comment.
Not to bikeshed, but wouldn't it be better to talk about how the polling system specifically handles the syscall management for the scheduler? As worded, this seems to handwave at the entire WSTP + IOFiber semantic space, which obviously polling systems don't touch.
There was a problem hiding this comment.
As worded, this seems to handwave at the entire WSTP + IOFiber semantic space
LOL yes this needs improvement. It's a couple iterations of copy pasta 🤪
Not to bikeshed, but wouldn't it be better to talk about how the polling system specifically handles the syscall management for the scheduler?
What exactly do you have in mind? Really only io_uring comes close to fully taking over syscall management.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.