Revert "kgo: avoid updating metadata before issuing ListOffsets / OffsetForLeaderEpoch #1188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setForLeaderEpoch" Meant to merge #1174. Upon further analysis, the metadata update is called anyway: sharding uses fetchMappedMetadata, which issues a metadata request if it's been more than metadataMinAge. The downside of doing this only through fetchMappedMetadata is that that codepath *only* updates the map, not the client's internal metadata that it uses for producing and consuming. So, not only do we not reduce the number of metadata requests, we actually propagate the information less with the commit. This reverts commit 88696a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to merge #1174.
Upon further analysis, the metadata update is called anyway: sharding uses fetchMappedMetadata, which issues a metadata request if it's been more than metadataMinAge. The downside of doing this only through fetchMappedMetadata is that that codepath only updates the map, not the client's internal metadata that it uses for producing and consuming. So, not only do we not reduce the number of metadata requests, we actually propagate the information less with the commit.
This reverts commit 88696a4.