feat(keyboard-key): create package #4136
Conversation
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 7ce2925 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🦋 Changeset detectedLatest commit: bff42f7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:XL
| @@ -59,11 +58,11 @@ export interface KeyboardKeyProps extends HTMLPasteProps<"div"> { | |||
| * @type string | |||
| * @memberof KeyboardKeyProps | |||
| */ | |||
| keyText?: string; | |||
| keyEvent?: string; | |||
There was a problem hiding this comment.
suggestion (non-blocking): maybe add to the description comment here that the docs have a chart of usable keyEvents? or a link to the map that you were using at one point?
slash would it make sense to limit the type of keyEvent from string to an actual list of usable key codes? I'm guessing no for scalability, but wanted to ask
There was a problem hiding this comment.
A really great suggestion. Pushing up the comment update. We can use the event.which which is the code number. It's something I feel developers would be more used to but it changes based on browser as mentioned in the link to the table. It is also deprecated so browsers at some point in the future may stop returning that field.
krisantrobus
dismissed stale reviews from serifluous and nkrantz
via
2542004
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
create-keyboard-key
|
| Run status |
|
| Run duration | 06m 05s |
| Commit |
|
| Committer | krisantrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
This pull request introduces a new
KeyboardKeycomponent. It's purpose is to display visual indicators for keyboard shortcuts available to users.