-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data-grid): change isCell function into a type guard and remove unnecessary type assertions #3516
Conversation
… unnecessary type assertions
|
Name | Link |
---|---|
🔨 Latest commit | 86c7b1c |
Run & review this pull request in StackBlitz Codeflow. |
|
Name | Link |
---|---|
🔨 Latest commit | 3dfd3e1 |
🦋 Changeset detectedLatest commit: 25c84ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 25c84ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 25c84ea:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement! Really nice work!
Small fix for our changeset and I can merge this today
done! |
change data grid
isCell
function into a type guard and remove unnecessary type assertions.