Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-grid): change isCell function into a type guard and remove unnecessary type assertions #3516

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

abereghici
Copy link
Contributor

change data grid isCell function into a type guard and remove unnecessary type assertions.

@netlify
Copy link

netlify bot commented Oct 4, 2023

‼️ Deploy request for paste-theme-designer rejected.

Name Link
🔨 Latest commit 86c7b1c

@stackblitz
Copy link

stackblitz bot commented Oct 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@netlify
Copy link

netlify bot commented Oct 4, 2023

‼️ Deploy request for paste-docs rejected.

Name Link
🔨 Latest commit 3dfd3e1

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2023

🦋 Changeset detected

Latest commit: 25c84ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@twilio-paste/data-grid Patch
@twilio-paste/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Oct 4, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 25c84ea. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25c84ea:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

Copy link
Contributor

@TheSisb TheSisb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! Really nice work!

Small fix for our changeset and I can merge this today

@abereghici
Copy link
Contributor Author

Thanks for the improvement! Really nice work!

Small fix for our changeset and I can merge this today

done!

@TheSisb TheSisb merged commit a684a6b into twilio-labs:main Oct 5, 2023
13 of 18 checks passed
@TwilioPasteBot TwilioPasteBot mentioned this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants