Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): add list-numbers, transfers template #454

Merged
merged 55 commits into from
Nov 6, 2023

Conversation

dsTw5
Copy link
Contributor

@dsTw5 dsTw5 commented Oct 10, 2023

this function lists the active numbers on a Twilio account or its subaccounts

this is to copy this function to twilio Labs github, to review it with an engineer and move it to QuickDeploy

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

Related issues

@dsTw5 dsTw5 changed the title LIST_NUMBERS LIST_NUMBERS+TRANSFERS Oct 13, 2023
@BlakePetersen
Copy link
Collaborator

It looks like that naming pattern is kabob-case rathe than camelCase. Can we rename the template to use kabob-case, "list-numbers"?

@dsTw5 dsTw5 changed the title LIST_NUMBERS+TRANSFERS feat(templates): add list-numbers, transfers template Oct 30, 2023
Copy link
Contributor

@chaosdone chaosdone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to see if the error Assign Reviewers gone there... please dont merge until we verify the change together

@dkundel dkundel merged commit 9657d6a into twilio-labs:main Nov 6, 2023
Copy link

welcome bot commented Nov 6, 2023

Congratulations on your first contribution to the Twilio Function Templates!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
To stay up-to-date with Twilio open source related updates, sign up here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants