Admin panel fixes #10792
Admin panel fixes #10792
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Here's my review of the admin panel fixes PR:
This PR enhances the admin panel UI with improved component organization, consistent styling, and better visual hierarchy across environment variables, health status, and workspace management sections.
- Added new
SettingsAdminTableCardcomponent for standardized table layouts within cards, improving UI consistency - Improved environment variables display with better spacing and expandable rows using
TableBodycomponents - Extracted
WorkerMetricsTooltipinto separate component with themed styling for better metrics visualization - Simplified health indicator labels by removing redundant "Status" suffix and standardizing descriptions
- Added
IconEyeShareandIconIdfor enhanced visual feedback in workspace impersonation features
The changes focus on UI refinements while maintaining existing functionality, making the admin panel more polished and maintainable.
16 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
.../twenty-front/src/modules/settings/admin-panel/components/SettingsAdminEnvVariablesTable.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/admin-panel/components/SettingsAdminTableCard.tsx
Outdated
Show resolved
Hide resolved
...s/twenty-front/src/modules/settings/admin-panel/components/SettingsAdminVersionContainer.tsx
Outdated
Show resolved
Hide resolved
...s/twenty-front/src/modules/settings/admin-panel/components/SettingsAdminWorkspaceContent.tsx
Outdated
Show resolved
Hide resolved
...nty-front/src/modules/settings/admin-panel/health-status/components/WorkerMetricsTooltip.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/settings/components/SettingsListItemCardContent.tsx
Show resolved
Hide resolved
packages/twenty-front/src/pages/settings/admin-panel/SettingsAdminIndicatorHealthStatus.tsx
Outdated
Show resolved
Hide resolved
...s/twenty-server/src/engine/core-modules/admin-panel/constants/health-indicators.constants.ts
Outdated
Show resolved
Hide resolved
| @@ -2,6 +2,7 @@ import styled from '@emotion/styled'; | |||
|
|
|||
| const StyledText = styled.span` | |||
| color: ${({ theme }) => theme.font.color.tertiary}; | |||
| white-space: pre-wrap; | |||
There was a problem hiding this comment.
@Devessier can we do this? Or would we prefer ellipses? @Bonapara suggested ellipses, but won't that crop important information?
before:
2025-03-12.02-10-05.mov
after:
There was a problem hiding this comment.
Thank you, @ehconitin. I think the best solution would be to make the container scrollable. That's what I did in https://github.com/twentyhq/twenty/blob/4d0450069c43b7059c4adcd1d1925ab84d7bb1aa/packages/twenty-front/src/modules/workflow/workflow-steps/components/WorkflowRunStepInputDetail.tsx.
If you want to display a big nested object, the JSON visualizer would become quite unreadable.
No description provided.