Fix mobile table styling outside record table (#10407) #10663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors mobile table styling by removing data-testid-based styles and introducing a new label visibility system for chip fields in mobile views.
- Added new
useIsChipFieldDisplayLabelHiddenhook in/packages/twenty-front/src/modules/object-record/record-field/meta-types/display/hooks/useIsChipFieldDisplayLabelHidden.tsto manage label visibility based on mobile context - Removed mobile-specific styling from
RecordTableBodythat was using data-testid selectors - Added
isLabelHiddenprop propagation throughChipFieldDisplay->RecordChip->LinkAvatarChip->Chipcomponent chain - Modified
RecordTableCellSoftFocusModeto hide first column button on mobile devices - Fixed
ChipFieldDisplayerror when used outside record table context with fallback instanceId
8 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...ules/object-record/record-field/meta-types/display/hooks/useIsChipFieldDisplayLabelHidden.ts
Show resolved
Hide resolved
packages/twenty-ui/src/display/avatar-chip/components/LinkAvatarChip.tsx
Show resolved
Hide resolved
eliasylonen
commented
Mar 4, 2025
|
|
||
| const isRecordTableScrolledLeft = useRecoilComponentValueV2( | ||
| isRecordTableScrolledLeftComponentState, | ||
| instanceStateContext?.instanceId || 'EMPTY', // TODO: Ugly, find a better way to avoid throwing when instance state context is not found |
There was a problem hiding this comment.
This has to be changed before merging.
This EMPTY placeholder is here to make useAvailableComponentInstanceIdOrThrow inside useRecoilComponentValueV2 not throw if instance state context is not found.
One option could be to add a parameter like throwOnMissingInstanceStateContext to useRecoilComponentValueV2.
What do you think @lucasbordeau, would that be a good solution?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #10407 now including a fix to
ChipFieldDisplaythrowing an error outside a record table.This works now, but refactoring is needed before merging.