Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Offcanvas scroll after close option #40553

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Xcreen
Copy link

@Xcreen Xcreen commented Jun 12, 2024

Description

I added a option scrollAfterClose to be able to disable the scrolling to the offcanvas toggler after the offcanvas is closed.

Motivation & Context

Currently after the offcanvas is closed, the body always scrolling back to the offcanvas toggler position.
When enable offcanvas bodyscrolling and add anchor-links into the offcanvas, the links dont work.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

Closes #38070

@patrickhlauke
Copy link
Member

noting that this isn't about scrolling. scrolling is a side effect of focus being (correctly) set back to the element that triggered the offcanvas. so, at the very least, rename this to be about focus, not scroll.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

offcanvas scrolls back to trigger element on close
3 participants