Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: updates for build-container action #1642

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

chewitt
Copy link
Member

@chewitt chewitt commented Feb 17, 2024

This updates the action versions to resolve the following warning:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, docker/setup-qemu-action@v2, docker/setup-buildx-action@v2, docker/login-action@v2, docker/metadata-action@v4, docker/build-push-action@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

It also adds concurrency so build runs are cancelled if the PR is force-push updated before they complete, and it renames the file from .yaml to .yml for consistency with other actions.

Copy link

@prplex prplex bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. No issues found.

Copy link

sonarcloud bot commented Feb 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Flole998
Copy link
Member

The concurrency change will likely have unintended side-effects: Here we have a single file for PRs and Repo publishing, when there are fast merges not all builds will be published to the repo. That's not intended, the repo should contain all builds.

@chewitt
Copy link
Member Author

chewitt commented Feb 18, 2024

The concurrency criteria includes the PR: group: ${{ github.workflow }}-${{ github.event.pull_request.number }} so force-pushing to a PR will cancel existing jobs for that PR and requeue with the latest changes. If you have other PR's building at the same time these won't be impacted as they're tracked under a separate identifier.

@Flole998
Copy link
Member

Yes I understand that, but this job is special: It does not only run on PRs, but also on master (with the additional step of publishing the container to the repo). So what will happen when 2 PRs are quickly merged into master? Will the second one cancel the first one? Or do they run one after the other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants