Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find correct path to .zshrc #14

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Conversation

thales-maciel
Copy link
Contributor

Zsh provides a way to keep all related files in a separate directory by exporting a ZDOTDIR variable, but the install script doesn't check It.

This is a minor issue, but may lead to some bad first time experience for some users, since the required lines would be added in a .zshrc file that is never sourced.

Copy link

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, same experience over here.

Wanted to submit an equivalent change request and stumbled over the PR.

@penberg penberg merged commit 24a9a77 into tursodatabase:main Aug 31, 2024
3 checks passed
@penberg
Copy link
Contributor

penberg commented Aug 31, 2024

Thanks @thales-maciel and @ttytm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants