Skip to content

Fix release workflow homebrew PR title check#4983

Merged
kaidaguerre merged 1 commit into
developfrom
fix-homebrew-pr-title-check
Apr 23, 2026
Merged

Fix release workflow homebrew PR title check#4983
kaidaguerre merged 1 commit into
developfrom
fix-homebrew-pr-title-check

Conversation

@kaidaguerre
Copy link
Copy Markdown
Contributor

Summary

Fix a bug in 01 - Steampipe: Release that causes update_homebrew_tap to always fail (and trigger_smoke_tests to be skipped) on final releases.

Root cause

The homebrew PR is created in create_pr_in_homebrew with title:

Steampipe <version>

using env.Version (raw input, e.g. 2.4.1, no v prefix).

The later check in update_homebrew_tap compared the PR title against:

Steampipe <VERSION>

using env.VERSION (calculated as v<input>, with v prefix, e.g. v2.4.1).

These never match. Result: the auto-merge of the brew formula PR always fails, and the post-release smoke tests are skipped.

Evidence

Fix

Change the comparison RHS from ${{ env.VERSION }} (with v) to ${{ github.event.inputs.version }} (without v) to match the PR title convention the workflow itself produces.

Backport

Should cherry-pick to v2.4.x (and other live release branches) so future patch releases don't hit the same bug.

Test plan

  • Diff inspected — single-line change
  • Will validate on the next real release (can't easily unit-test a workflow change)

Related

The homebrew PR is created with title 'Steampipe <version>' (no v prefix,
using github.event.inputs.version via env.Version). The later check
compared against 'Steampipe v<version>' (using env.VERSION which prepends
a v). Mismatch caused update_homebrew_tap to always fail after tagging,
which then skipped trigger_smoke_tests.

Fix: check against github.event.inputs.version to match the PR title
convention used across historical homebrew-tap PRs (Steampipe 2.3.5,
2.3.6, 2.4.0, 2.4.1).
@kaidaguerre kaidaguerre merged commit fd9bc28 into develop Apr 23, 2026
28 of 29 checks passed
@kaidaguerre kaidaguerre deleted the fix-homebrew-pr-title-check branch April 23, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants