Fix release workflow homebrew PR title check#4983
Merged
Merged
Conversation
The homebrew PR is created with title 'Steampipe <version>' (no v prefix, using github.event.inputs.version via env.Version). The later check compared against 'Steampipe v<version>' (using env.VERSION which prepends a v). Mismatch caused update_homebrew_tap to always fail after tagging, which then skipped trigger_smoke_tests. Fix: check against github.event.inputs.version to match the PR title convention used across historical homebrew-tap PRs (Steampipe 2.3.5, 2.3.6, 2.4.0, 2.4.1).
MichaelBurgess
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in
01 - Steampipe: Releasethat causesupdate_homebrew_tapto always fail (andtrigger_smoke_teststo be skipped) on final releases.Root cause
The homebrew PR is created in
create_pr_in_homebrewwith title:using
env.Version(raw input, e.g.2.4.1, novprefix).The later check in
update_homebrew_tapcompared the PR title against:using
env.VERSION(calculated asv<input>, withvprefix, e.g.v2.4.1).These never match. Result: the auto-merge of the brew formula PR always fails, and the post-release smoke tests are skipped.
Evidence
vconvention: views (in public schema) deleted when caching enabled #219 "Steampipe 2.3.5", cap column width to available cols in screen. Closes #155 #221 "Steampipe 2.3.6", Cache retrieves incorrect data for multi connection queries #223 "Steampipe 2.4.0", set search_path tosteampipeuser. Closes #218 #225 "Steampipe 2.4.1",spinnershould not come up in non-interactive query mode. Closes #227 #228 "Steampipe 2.4.2".update_homebrew_tapat this check, exactly atIncorrect version→exit 1.Fix
Change the comparison RHS from
${{ env.VERSION }}(withv) to${{ github.event.inputs.version }}(withoutv) to match the PR title convention the workflow itself produces.Backport
Should cherry-pick to
v2.4.x(and other live release branches) so future patch releases don't hit the same bug.Test plan
Related