Fix autocomplete regression: suggestions disappear when typing table name after 'from ' #4929
+51
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name after 'from ' closes #4928 Revert the `endsWithSpace` check in `isEditingTable()` that was introduced in #4884. That check caused `isEditingTable` to return false as soon as the user started typing a table name (e.g. `select * from aws`), because the text no longer ended with a space. This made the autocomplete dropdown disappear entirely instead of filtering suggestions by the typed prefix. The original `prevWord == "from"` check is sufficient: while the user is typing a table name, `prevWord` remains "from", so suggestions are shown and filtered by `FilterHasPrefix`. Once the user finishes the table name and types a space (moving to WHERE, etc.), `prevWord` becomes the table name, correctly stopping table suggestions. The `getPreviousWord()` fix from #4884 (handling single-word inputs like "from ") is retained as it was correct. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.6 <[email protected]>
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression introduced in v2.3.3 where autocomplete suggestions disappear when users start typing a table name after from . The fix reverts the isEditingTable() function to rely on the simple prevWord == "from" check, allowing the existing FilterHasPrefix mechanism in queryCompleter to properly filter suggestions as users type.
Changes:
- Reverted
isEditingTable()to the pre-#4884 implementation that checks onlyprevWord == "from", removing the problematicendsWithSpacecheck - Updated all tests to match the single-argument signature of
isEditingTable() - Added comprehensive regression test cases covering various scenarios of typing table names
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/interactive/interactive_helpers.go | Simplified isEditingTable() to take only prevWord parameter and check prevWord == "from", removing the endsWithSpace guard that caused the regression |
| pkg/interactive/interactive_helpers_test.go | Updated TestIsEditingTable to use single-argument signature and added test case for table name after from; added regression test cases to TestGetQueryInfo covering typing table names, partial names, and qualified names |
| pkg/interactive/interactive_client_test.go | Updated TestGetQueryInfo_FromDetection with corrected expectations and added from_table_done test case; enhanced comments to reference both #4810 and #4928 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
graza-io
approved these changes
Feb 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fromendsWithSpacecheck was added toisEditingTable(), causing it to returnfalsewhile typing a table name prefixisEditingTable()back to the simpleprevWord == "from"check, which correctly relies onFilterHasPrefixinqueryCompleterto narrow suggestions as the user typesgetPreviousWord()fix from Fix getQueryInfo() 'from ' detection closes #4810 (rebased) #4884Test plan
TestIsEditingTable— updated for reverted single-arg signature, added "table name after from" caseTestGetQueryInfo— added regression test cases:typing table name after from,typing partial table name,typing qualified table name,past table into where clauseTestGetQueryInfo_FromDetection— fixed expectations and addedfrom_table_donecasepkg/interactive/passselect * from awsin interactive prompt and confirm suggestions filter correctly🤖 Generated with Claude Code