Add initial Cloud Build connection table #755
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Cloud Build v2 connection table along with required dependency updates to support it. Key changes include updating go.mod dependency versions (including adding cloudbuild v1.22.2), implementing the connection table with listing and hydrate functions, and adding documentation for the new table.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated dependency versions and added cloudbuild module |
| gcp/table_gcp_cloudbuildv2_connection.go | Added table implementation, list, get, and transform functions for Cloud Build v2 connections |
| gcp/service.go | Added CloudBuildV2Service function to create and cache the service |
| gcp/plugin.go | Registered the new table in the plugin |
| docs/tables/gcp_cloudbuildv2_connection.md | Added documentation and example queries for the new table |
|
|
||
| func listGcpCloudbuildv2Locations(ctx context.Context, d *plugin.QueryData, _ *plugin.HydrateData) (interface{}, error) { | ||
| // have we already created and cached the locations? | ||
| locationCacheKey := "CloudBuildV2" |
There was a problem hiding this comment.
[nitpick] Consider defining cache key values as constants at a shared location to improve maintainability and avoid potential duplication or typos in the future.
| locationCacheKey := "CloudBuildV2" |
Copilot uses AI. Check for mistakes.
| plugin.Logger(ctx).Trace("getCloudBuildV2Service") | ||
|
|
||
| // have we already created and cached the service? | ||
| serviceCacheKey := "CloudBuildV2Service" |
There was a problem hiding this comment.
[nitpick] Consider defining cache key constants in a common file or section to ensure consistency and ease potential future updates.
Copilot uses AI. Check for mistakes.
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
github-actions
bot
added
the
stale
Remaining work/questions: